[PFS-171] Update onUpsert Interface, Refactor StartCommit #10253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
4cc2fcd to
fd86c75
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10253 +/- ##
==========================================
- Coverage 58.77% 58.70% -0.07%
==========================================
Files 637 637
Lines 77027 77033 +6
==========================================
- Hits 45271 45223 -48
- Misses 31198 31251 +53
- Partials 558 559 +1 ☔ View full report in Codecov by Sentry. |
Zhang-Muyang
reviewed
Aug 6, 2024
| return errors.Wrap(err, "update commit") | ||
| } | ||
| if err := atomicUpsertBranchAndCommitBranch(ctx, txnCtx.SqlTx, branchInfo, newHead.ID); err != nil { | ||
| return errors.Wrap(err, "fill new branches") |
There was a problem hiding this comment.
I feel callers of fillNewBranches may wrap the error around "fill new branches". So it might better if it can indicate upsert branch.
There was a problem hiding this comment.
something like "fill new branches: upsert branch"?
| } | ||
|
|
||
| func (a *apiServer) validateStartCommitArgs(ctx context.Context, txnCtx *txncontext.TransactionContext, branchHandle *pfs.Branch) error { | ||
| // Validate arguments: |
There was a problem hiding this comment.
this comment might be unnecessary now. The err msg and function name indicate the purpose
Zhang-Muyang
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next PR will be an update that actually creates an internal commit model that we can use. This will be handiest in functions like inspect commit which have to re-resolve the commit handles for provenance and such.