feat: add Windows venv wrappers support #768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
6c2354b to
28c56cf
Compare
🚀 Build artifacts are ready for testing!Download the wheel file and binaries with gh CLI or from the workflow artifacts. 📦 Install & RunPre-requisites# Install uv if needed
curl -LsSf https://astral.sh/uv/install.sh | sh
# Create and enter artifacts directory
mkdir artifacts && cd artifactsQuick Test with Python Package# Download and run with uv
gh run download 16037481309 -n dist -R pyupio/safety
uv run --with safety-3.5.2+feat.add.windows.venv.support-py3-none-any.whl safety --versionBinary Installation# Linux
gh run download 16037481309 -n safety-linux -D linux -R pyupio/safety
cd linux && mv safety safety-pr && chmod +x safety-pr
# macOS
gh run download 16037481309 -n safety-macos -D macos -R pyupio/safety
cd macos && mv safety safety-pr && chmod +x safety-pr
# Windows
gh run download 16037481309 -n safety-windows -D windows -R pyupio/safety
cd windows && mv safety.exe safety-pr.exe
./safety-pr --version
|
9db81e9 to
4ce49b4
Compare
4ce49b4 to
215aa7a
Compare
215aa7a to
5036f67
Compare
Windows lacks built-in shell aliases like Unix's bashrc, so Safety uses .bat wrappers in a scripts directory prepended to PATH. However, when users activate a virtual environment, the venv's Scripts directory gets prepended to PATH, causing commands like 'pip' to bypass our Safety wrappers entirely. This implementation solves the issue by adding doskey aliases for CMD (via AutoRun registry) and PowerShell functions (via profile scripts), ensuring Safety's command interception works regardless of PATH order changes during venv activation.
5036f67 to
c1aaa27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for virtualenvs on Windows PowerShell and CMD.exe
Windows lacks built-in shell aliases like Unix's bashrc, so Safety uses .bat wrappers in a scripts directory prepended to PATH. However, when users activate a virtual environment, the venv's Scripts directory gets prepended to PATH, causing commands like 'pip' to bypass our Safety wrappers entirely. This implementation solves the issue by adding doskey aliases for CMD (via AutoRun registry) and PowerShell functions (via profile scripts), ensuring Safety's command interception works regardless of PATH order changes during venv activation.