Skip to content

fix: use tomllib in tests if available #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

fix: use tomllib in tests if available #765

merged 1 commit into from
Jun 22, 2025

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Jun 21, 2025

Description

Update conftest.py to use tomllib in Python 3.11+, and tomli otherwise. This removes the only remaining dependency on tomli for modern Python versions. This is needed since Linux distributions such as Gentoo are working on removing tomli packages as they remove support for Python < 3.11.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • Other (please describe): test change

Related Issues

Testing

  • Tests added or updated
  • No tests required

The change is updating tests, and they still pass with it (and with tomli uninstalled).

Checklist

  • Code is well-documented
  • Changelog is updated (if needed)
  • No sensitive information (e.g., keys, credentials) is included in the code
  • All PR feedback is addressed

Additional Notes

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 21, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mgorny mgorny mentioned this pull request Jun 21, 2025
Open
3 tasks
@mgorny
Copy link
Contributor Author

mgorny commented Jun 21, 2025

I've noticed the file wasn't formatted, so tried to keep existing style. Should I reformat it?

@yeisonvargasf
Copy link
Member

I've noticed the file wasn't formatted, so tried to keep existing style. Should I reformat it?

Hi, thanks for your contribution!

Yes, in the following line you can find the commands we use for formatting:

safety/pyproject.toml

Line 247 in 03e057b

fmt = [

Remember to squash this branch after you format the changes. Thanks!

@mgorny
test: use tomllib in tests if available
a81cdf6 
Update `conftest.py` to use `tomllib` in Python 3.11+, and `tomli`
otherwise.  This removes the only remaining dependency on `tomli`
for modern Python versions.  This is needed since Linux distributions
such as Gentoo are working on removing `tomli` packages as they remove
support for Python < 3.11.

Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
Copy link
Contributor Author

mgorny commented Jun 21, 2025

Done.

@mgorny mgorny mentioned this pull request Jun 22, 2025
Closed
1 task
@yeisonvargasf yeisonvargasf self-requested a review June 22, 2025 17:08
yeisonvargasf
yeisonvargasf approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@yeisonvargasf yeisonvargasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@yeisonvargasf yeisonvargasf merged commit f1e3d4d into pyupio:main Jun 22, 2025
27 of 28 checks passed
@mgorny mgorny deleted the test-tomli branch June 22, 2025 17:24
@mgorny
Copy link
Contributor Author

mgorny commented Jun 22, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeisonvargasf yeisonvargasf yeisonvargasf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgorny @yeisonvargasf