Skip to content

feat: included project id in project specific files #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

feat: included project id in project specific files #736

merged 1 commit into from
May 6, 2025

Conversation

jakub-safetycli
Copy link
Collaborator

Description

Includes the project ids in the generated Firewall urls in the project specific configuration i.e. requirements.txt, or pyproject.toml for poetry and uv.

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • Other (please describe):

Related Issues

Testing

  • Tests added or updated
  • No tests required

Checklist

  • Code is well-documented
  • Changelog is updated (if needed)
  • No sensitive information (e.g., keys, credentials) is included in the code
  • All PR feedback is addressed

Additional Notes

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 6, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jakub-safetycli jakub-safetycli added the enhancement Suggests an improvement or new feature. label May 6, 2025
@jakub-safetycli jakub-safetycli force-pushed the feature/project-url-paths branch 2 times, most recently from 20a42e8 to a58d9a9 Compare May 6, 2025 19:49
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

🚀 Build artifacts are ready for testing!

Download the wheel file and binaries with gh CLI or from the workflow artifacts.

📦 Install & Run

Pre-requisites

# Install uv if needed
curl -LsSf https://astral.sh/uv/install.sh | sh

# Create and enter artifacts directory
mkdir artifacts && cd artifacts

Quick Test with Python Package

# Download and run with uv
gh run download 14870127100 -n dist -R pyupio/safety
uv run --with safety-3.5.0b1+feature.project.url.paths-py3-none-any.whl safety --version

Binary Installation

# Linux
gh run download 14870127100 -n safety-linux -D linux -R pyupio/safety
cd linux && mv safety safety-pr && chmod +x safety-pr

# macOS
gh run download 14870127100 -n safety-macos -D macos -R pyupio/safety
cd macos && mv safety safety-pr && chmod +x safety-pr

# Windows
gh run download 14870127100 -n safety-windows -D windows -R pyupio/safety
cd windows && mv safety.exe safety-pr.exe

./safety-pr --version

Note: You need to be logged in to GitHub to access the artifacts.

@jakub-safetycli jakub-safetycli force-pushed the feature/project-url-paths branch 2 times, most recently from 2abf400 to b08754b Compare May 6, 2025 19:56
@jakub-safetycli jakub-safetycli marked this pull request as ready for review May 6, 2025 20:01
@jakub-safetycli jakub-safetycli force-pushed the feature/project-url-paths branch from b08754b to 7ca30db Compare May 6, 2025 20:14
@jakub-safetycli jakub-safetycli force-pushed the feature/project-url-paths branch from 7ca30db to d9234f3 Compare May 6, 2025 21:19
yeisonvargasf
yeisonvargasf requested changes May 6, 2025
View reviewed changes
Copy link
Member

@yeisonvargasf yeisonvargasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a fix to do on the configure_local_directory call

@jakub-safetycli jakub-safetycli force-pushed the feature/project-url-paths branch from d9234f3 to 8ccc370 Compare May 6, 2025 21:28
@jakub-safetycli jakub-safetycli force-pushed the feature/project-url-paths branch from 8ccc370 to c8f85a9 Compare May 6, 2025 21:31
@yeisonvargasf yeisonvargasf self-requested a review May 6, 2025 21:32
yeisonvargasf
yeisonvargasf approved these changes May 6, 2025
View reviewed changes
Copy link
Member

@yeisonvargasf yeisonvargasf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakub-safetycli jakub-safetycli merged commit 9328620 into main May 6, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeisonvargasf yeisonvargasf yeisonvargasf approved these changes

Assignees

@yeisonvargasf yeisonvargasf

Labels
enhancement Suggests an improvement or new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakub-safetycli @yeisonvargasf