Skip to content

Add missing TypedDict special case to checkmember.py #18604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sterliakov
Copy link
Collaborator

Fixes #18600.

This comment has been minimized.

@sterliakov sterliakov force-pushed the bugfix/st-typeddict-lost-when-inherited branch from 1039040 to 8de88f2 Compare February 5, 2025 02:14
@sterliakov sterliakov marked this pull request as ready for review February 5, 2025 02:22
Copy link
Contributor

github-actions bot commented Feb 5, 2025

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick fix!

@hauntsaninja hauntsaninja merged commit 6f32ef9 into python:master Feb 5, 2025
18 checks passed
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypedDict arguments are not recognized if a base class's nested class is accessed via a subclass
2 participants