Skip to content

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Jan 26, 2025

The error messages for some math functions got changed in python/cpython#124299. Adjust mypyc to emit the same ones.

Fixes mypyc/test/test_run.py::TestRun::run-math.test::testMathOps

@cdce8p cdce8p added the topic-mypyc mypyc bugs label Jan 26, 2025
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JukkaL JukkaL merged commit 065c8fa into python:master Jan 27, 2025
12 checks passed
@cdce8p cdce8p deleted the mypyc-math branch January 27, 2025 10:16
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
The error messages for some math functions got changed in
python/cpython#124299. Adjust mypyc to emit the
same ones.

Fixes `mypyc/test/test_run.py::TestRun::run-math.test::testMathOps`
hauntsaninja pushed a commit that referenced this pull request Apr 22, 2025
Followup to #18534

Some more error messages for math functions were changed for Python
3.14, see python/cpython#129497.

Fixes `mypyc/test/test_run.py::TestRun::run-math.test::testMathOps`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-mypyc mypyc bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants