Synchronize test-requirements.txt and .pre-commit-config.yaml #15197
Conversation
The two files got out of sync after python#15167
|
flake8 v6.0.0 doesn't support python 3.7 :/ |
|
We should probably go back to flake8 5 in that case. |
And add a comment to |
|
OK isort says hi now :D |
.pre-commit-config.yaml
Outdated
| @@ -4,11 +4,11 @@ repos: | |||
| hooks: | |||
| - id: black | |||
| - repo: https://github.com/pycqa/isort | |||
| rev: 5.12.0 # must match test-requirements.txt | |||
| rev: 5.11.5 # must match test-requirements.txt (cannot use version 2.12 until python 3.7 support is dropped) | |||
There was a problem hiding this comment.
:)
| rev: 5.11.5 # must match test-requirements.txt (cannot use version 2.12 until python 3.7 support is dropped) | |
| rev: 5.11.5 # must match test-requirements.txt (cannot use version 5.12 until python 3.7 support is dropped) |
There was a problem hiding this comment.
Sorry pushed before your comment :/
|
It is probably better to run the linting CI on a newer version of python so that you don't have to deal with this situation anymore. Do you want me to make a PR or maybe update this one? |
Yeah, just because we support Python 3.7 doesn't mean that we support the project being linted on Python 3.7. So I think that would be fine, and would make the situation easier |
|
You could also update the pinned versions of flake8-bugbear and flake8-noqa. (There are no new hits from either of them.) If we stick with flake8 v5, we can't upgrade to the latest version of flake8-bugbear (23.3.23), which requires flake8 v6, so we can only upgrade to flake8-bugbear==23.3.12. flake8-noqa can be upgraded to the latest version (1.3.1). |
Do you propose that I change it in this PR or a separate one? |
I guess a separate PR maybe makes more sense since we'd be changing our testing setup (and this PR is fixing the setup rather than changing how it works) — but no strong opinion either way |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
The two files got out of sync after #15167
(Explain how this PR changes mypy.)