Skip to content

Move truthy-function docs from “optional checks” to “enabled by default” #14380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

Move truthy-function docs from “optional checks” to “enabled by default” #14380

merged 1 commit into from
Jan 11, 2023

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jan 3, 2023

This error was enabled by default since its introduction (#13686); document it in the correct section.

@andersk andersk mentioned this pull request Jan 3, 2023
Merged
cdce8p
cdce8p approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andersk! LGTM

hauntsaninja
hauntsaninja approved these changes Jan 3, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

hauntsaninja
hauntsaninja reviewed Jan 3, 2023
View reviewed changes
hauntsaninja
hauntsaninja requested changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for the anchor fix)

@andersk
Move truthy-function docs from “optional checks” to “enabled by default”
be1bfe9 
This error was enabled by default since its introduction (python#13686);
document it in the correct section.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk force-pushed the truthy-function-doc branch from dce7e03 to be1bfe9 Compare January 10, 2023 07:00
@andersk
Copy link
Contributor Author

andersk commented Jan 10, 2023

Oops, fixed.

@hauntsaninja hauntsaninja merged commit 13e6617 into python:master Jan 11, 2023
@hauntsaninja
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja requested changes

+1 more reviewer

@cdce8p cdce8p cdce8p approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andersk @hauntsaninja @cdce8p