Skip to content

stubtest: catch BaseException on imports #14284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2022
Merged

stubtest: catch BaseException on imports #14284

merged 3 commits into from
Dec 12, 2022

Conversation

hauntsaninja
Copy link
Collaborator

This came up in python/typeshed#9347

AlexWaygood
AlexWaygood reviewed Dec 11, 2022
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Dec 11, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@hauntsaninja hauntsaninja merged commit b0003af into python:master Dec 12, 2022
@hauntsaninja hauntsaninja deleted the import-system-exit branch December 12, 2022 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

+1 more reviewer

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hauntsaninja @JelleZijlstra @AlexWaygood