bpo-35279: reduce default max_workers of ThreadPoolExecutor #13618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45f1f43 to
d0d2ea3
Compare
d0d2ea3 to
4e7b131
Compare
tirkarthi
reviewed
May 28, 2019
Doc/library/concurrent.futures.rst
Outdated
| @@ -159,6 +159,15 @@ And:: | |||
| .. versionchanged:: 3.7 | |||
| Added the *initializer* and *initargs* arguments. | |||
|
|
|||
| .. versionchanged:: 3.8 | |||
| Default value of *max_workers* is changed to ``min(32, os.cpu_count() + 4)``. | |||
| This default value preserves at least 5 worker for I/O bound task. It utilize | |||
There was a problem hiding this comment.
Not a native English speaker but I think it should be "It utilizes" and "And it avoids" in the next sentence.
There was a problem hiding this comment.
Also, at least 5 workers. And I'm not sure if it should be for I/O bound tasks or 'for the I/O bound task`.
csabella
reviewed
May 28, 2019
Doc/library/concurrent.futures.rst
Outdated
| .. versionchanged:: 3.8 | ||
| Default value of *max_workers* is changed to ``min(32, os.cpu_count() + 4)``. | ||
| This default value preserves at least 5 worker for I/O bound task. It utilize | ||
| at most 32 CPU cores for CPU bound task which release GIL. And it avoid using |
There was a problem hiding this comment.
for CPU bound tasks and which release the GIL.
csabella
reviewed
May 28, 2019
Doc/library/concurrent.futures.rst
Outdated
| Default value of *max_workers* is changed to ``min(32, os.cpu_count() + 4)``. | ||
| This default value preserves at least 5 worker for I/O bound task. It utilize | ||
| at most 32 CPU cores for CPU bound task which release GIL. And it avoid using | ||
| very large resource implicitly on many core machines. |
wyaadarsh
reviewed
Dec 7, 2023
| It utilizes at most 32 CPU cores for CPU bound tasks which release the GIL. | ||
| And it avoids using very large resources implicitly on many-core machines. | ||
|
|
||
| ThreadPoolExecutor now reuses idle worker threads before starting |
There was a problem hiding this comment.
Where is the corresponding change in the code? For reusing the idle worker threads before starting max_workers worker threads?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue35279