-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Labels
area/coreRelated to the poetry-core libraryRelated to the poetry-core libraryarea/installerRelated to the dependency installerRelated to the dependency installerkind/bugSomething isn't working as expectedSomething isn't working as expectedstatus/waiting-on-coreRequires changes to poetry-core firstRequires changes to poetry-core first
Milestone
Description
Summary
With flask = { git = "git@github.com:pallets/flask.git", rev = "b90a4f1f4a370e92054b9cc9db0efcb864f87ebe" }
poetry write "url": "git@github.com:pallets/flask.git"
in direct_url.json
- Poetry version: cff4d7d
- Python version: 3.8.10 (irrelevant)
- OS version and name: Windows 11 (also happens on mac os)
- pyproject.toml: `
[tool.poetry]
name = "a"
version = "0.1.0"
description = ""
authors = ["konstin <konstin@mailbox.org>"]
readme = "README.md"
[tool.poetry.dependencies]
python = "^3.8"
flask = { git = "git@github.com:pallets/flask.git", rev = "b90a4f1f4a370e92054b9cc9db0efcb864f87ebe" }
[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"
- I am on the latest stable Poetry version, installed using a recommended method.
- I have searched the issues of this repo and believe that this is not a duplicate.
- I have consulted the FAQ and blog for any relevant entries or release notes.
- If an exception occurs when executing a command, I executed it again in debug mode (
-vvv
option) and have included the output below.
Issue
When using a git dependency, the url
field of the direct_url.json
that poetry writes is not a url. This causes problems in uv (astral-sh/uv#1744). The spec isn't clear about what the url field contains. I propose to change this both in poetry and in the spec: pypa/packaging.python.org#1506.
Metadata
Metadata
Assignees
Labels
area/coreRelated to the poetry-core libraryRelated to the poetry-core libraryarea/installerRelated to the dependency installerRelated to the dependency installerkind/bugSomething isn't working as expectedSomething isn't working as expectedstatus/waiting-on-coreRequires changes to poetry-core firstRequires changes to poetry-core first