Support list format fallbacks #1099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
tomasr8
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Looks good to me :) Full branch and statement coverage for babel.lists as well
As an aside, I was looking for some description for how the list patterns are defined in the XML and I only found this short explanation. I assume the <listPattern> with no type is the standard one?
It's (vaguely) in the TR35 doc:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1098 by fixing one part of #1076.
As noted in the TODO comment, this isn't the optimal way to implement it, but a better way could be swapped in later.