Fix for #990 #1006
Closed
Fix for #990 #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need some working tests before attempting to fix python-babel#990. Refs python-babel#990
In certain OS installations, the target of /etc/localtime contains double slashes. This is a valid path, but not a valid zoneinfo key. This fix replaces `os.readlink` with `os.path.realpath`, which is guaranteed to return a normalized path. Fixes python-babel#990
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1006 +/- ##
==========================================
- Coverage 90.90% 89.57% -1.34%
==========================================
Files 25 25
Lines 4356 4356
==========================================
- Hits 3960 3902 -58
- Misses 396 454 +58 ☔ View full report in Codecov by Sentry. |
This was referenced Oct 12, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
localtimemodule (developed on macOS, test stub added for Windows)All checks are passing except for some unrelated and previously-broken tests: