Skip to content

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Dec 9, 2023

We're tantalizingly close, and I didn't find a setting for requiring the patch diff to be 100% without the project needing to be 100%, so might as well slowly work towards it. I noticed I've been authoring PRs with very minor misses - and easier to enforce 100% at time of authoring a PR than fix afterward.

We're at 52 missed lines on master/ currently

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #2901 (1cf9272) into master (ba92264) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2901      +/-   ##
==========================================
+ Coverage   99.55%   99.66%   +0.10%     
==========================================
  Files         115      115              
  Lines       17668    17667       -1     
  Branches     3161     3157       -4     
==========================================
+ Hits        17590    17608      +18     
+ Misses         52       40      -12     
+ Partials       26       19       -7     
Files Coverage Δ
src/trio/_core/_tests/test_asyncgen.py 100.00% <100.00%> (+0.91%) ⬆️
src/trio/_core/_tests/test_guest_mode.py 100.00% <100.00%> (ø)
src/trio/_core/_tests/test_run.py 100.00% <ø> (ø)
src/trio/_core/_tests/tutil.py 100.00% <ø> (+1.88%) ⬆️
src/trio/_dtls.py 97.50% <ø> (+0.74%) ⬆️
src/trio/_subprocess.py 100.00% <ø> (+1.70%) ⬆️
src/trio/_tests/test_exports.py 99.60% <ø> (+0.76%) ⬆️
src/trio/_tests/test_highlevel_open_tcp_stream.py 100.00% <100.00%> (ø)
src/trio/_tests/test_highlevel_open_unix_stream.py 100.00% <100.00%> (ø)
src/trio/_tests/test_subprocess.py 100.00% <100.00%> (ø)
... and 2 more

... and 3 files with indirect coverage changes

@jakkdl
Copy link
Member Author

jakkdl commented Dec 9, 2023

PyPy 7.3.0 was released in december 2019, and I have no clue how long it's been since trio last ran 7.2.X in CI, so I think users still running 7.2.X have bigger problems than buggy asyncgens. But pypy versioning is weird so ... maybe warrants a release note?? @A5rocks

@A5rocks
Copy link
Contributor

A5rocks commented Dec 9, 2023

Looks like pypy 7.2.0 is only Python 3.6 so it's not in our supported versions anyways

Copy link
Contributor

@TeamSpen210 TeamSpen210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing test coverage is good indeed.

Copy link
Member

@CoolCat467 CoolCat467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great other than making sure we have a full discussion about the dtls handle_client_hello_untrusted thing

@CoolCat467
Copy link
Member

@jakkdl
Copy link
Member Author

jakkdl commented Dec 14, 2023

I think this looks great other than making sure we have a full discussion about the dtls handle_client_hello_untrusted thing

I think that requires more time/effort to fully delve into than it is worth, so I personally don't mind punting that to an unspecified time when somebody else works on the dtls stuff and stumbles upon it. Or if somebody reading this knows the dtls code well enough that they care to investigate and open a separate issue/PR.

@jakkdl jakkdl merged commit 4ba3f60 into python-trio:master Dec 14, 2023
@jakkdl jakkdl deleted the 100_percent_codecov_patch branch December 14, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants