Add timestamps to TestReport objects #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Black was failing with this error: ImportError: cannot import name '_unicodefun' from 'click' So I just ran 'pre-commit autoupdate'
HTRafal
commented
Feb 2, 2023
| @@ -47,13 +47,16 @@ def test_fail(): | |||
|
|
|||
| # rest of the json objects should be unserialized into report objects; we don't test | |||
| # the actual report object extensively because it has been tested in ``test_reports`` | |||
| # already. | |||
| # already (except start and stop attributes which are set by this plugin). | |||
There was a problem hiding this comment.
This edge case doesn't sound good though. Up to this point the only responsibility of this plugin was saving reportlog to a json file as is.
I don't know where this new feature fits best, so I created this pull request to start off the discussion.
Alternatively I can try to upstream it to pytest itself, here's a draft - HTRafal/pytest#1
Let me know what you guys think.
There was a problem hiding this comment.
As commented in HTRafal/pytest#1 (comment), seems like it would be a good fit to move the timestamps directly to the test report objects. 👍
There was a problem hiding this comment.
Got it, I opened a PR to core pytest instead - pytest-dev/pytest#10711
|
Closing in favor of pytest-dev/pytest#10711 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #19 - this PR timestamps in TestReport entries.