Add assert_has_calls_wrapper #359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
@nicoddemus Do you have time to take a look? |
|
Hi @Astral1020, Yes, thanks a lot for the contribution! I did take a glance at the implementation, will take a better look later today. Meanwhile, could you add one or more tests to cover the new function? Thanks! |
|
Added unit tests in #365, couldn't figure out how to commit to this :(( |
|
Superseded by #365, thanks @Astral1020! |
|
@nicoddemus Sorry I miss the notification, and thank you for keep my commit. |
|
Sure thing, thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this issue #234