Change the command for package building in release CI workflow #9229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoddemus
reviewed
Oct 22, 2021
| @@ -226,7 +226,7 @@ jobs: | |||
|
|
|||
| - name: Build package | |||
| run: | | |||
| python setup.py sdist bdist_wheel | |||
| python -m build | |||
There was a problem hiding this comment.
Don't we need to install this in the Install dependencies step above?
There was a problem hiding this comment.
this needs a install of build or a pipx call
There was a problem hiding this comment.
I added build to the Install dependencies step.
nicoddemus
reviewed
Oct 22, 2021
.github/workflows/main.yml
Outdated
| @@ -222,11 +222,11 @@ jobs: | |||
| - name: Install dependencies | |||
| run: | | |||
| python -m pip install --upgrade pip | |||
| pip install --upgrade wheel setuptools setuptools_scm[toml]>=6 tox | |||
| pip install --upgrade wheel setuptools build setuptools_scm[toml]>=6 tox | |||
There was a problem hiding this comment.
Technically we should not install setuptools explicitly, neither setuptools_scm I think
Suggested change
| pip install --upgrade wheel setuptools build setuptools_scm[toml]>=6 tox | |
| pip install --upgrade wheel build tox |
Can you confirm @RonnyPfannschmidt ?
There was a problem hiding this comment.
wheel is specified in the pyproject.toml, maybe we don't need to install it explicitly either?
bluetech
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9225.