Attribute error in TestCaseFunction.teardown when exception encountered before TestCaseFunction.setup is run. #3788
Description
The sample code below raises an exception in a unittest.TestCase class in the __init__ method. This will produce an exception in TestCaseFunction.teardown() because self._testcase isn't defined, but teardown() attempts to call it here:
pytest/src/_pytest/unittest.py
Line 97 in cbaa7dd
# cat test_setup_exception.py
import unittest
import pytest
class MuhUnitTests(unittest.TestCase):
def __init__(self):
raise Exception("testing123")
def test_passing(self):
assert True
# Execute Tests
def main():
pytest.main(['test_setup_exception.py', '-s'])
if __name__ == '__main__':
main()self = <TestCaseFunction 'test_passing'>
def teardown(self):
> if hasattr(self._testcase, "teardown_method"):
E AttributeError: 'TestCaseFunction' object has no attribute '_testcase'
../python3.6/site-packages/_pytest/unittest.py:96: AttributeError
Adding a check in teardown for existence of _testcase solves the issue and allows the exception to bubble correctly:
def teardown(self):
if hasattr(self, "_testcase") and hasattr(self._testcase, "teardown_method"):
self._testcase.teardown_method(self._obj)
# Allow garbage collection on TestCase instance attributes.
self._testcase = None
self._obj = None