Skip to content

Raise error when download=True for LFW dataset #8888 #9040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2025
Merged

Raise error when download=True for LFW dataset #8888 #9040

merged 4 commits into from
May 29, 2025

Conversation

youcefouadjer
Copy link
Contributor

LFW dataset is no longer available for download, this PR raises a RuntimeError when download=True in the _LFW class

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9040

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @youcefouadjer!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

NicolasHug
NicolasHug reviewed Apr 28, 2025
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @youcefouadjer . This LGTM, can you please also add a warning to the docstring?

@NicolasHug NicolasHug merged commit 13ada56 into pytorch:main May 29, 2025
1 check passed
@github-actions GitHub Actions
Copy link

Hey @NicolasHug!

You merged this PR, but no labels were added.
The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@NicolasHug NicolasHug mentioned this pull request May 29, 2025
Closed
facebook-github-bot pushed a commit that referenced this pull request Jul 30, 2025
@NicolasHug @facebook-github-bot
[fbsync] Raise error when download=True for LFW dataset #8888 (#9040)
d773ed9 
Reviewed By: AntoineSimoulin

Differential Revision: D79175064

fbshipit-source-id: 2f1cee6558ef0149ce5a7519b973a33295271f6a

Co-authored-by: Youcef OUADJER <71473188+youcefvision@users.noreply.github.com>
Co-authored-by: Nicolas Hug <contact@nicolas-hug.com>
Co-authored-by: Nicolas Hug <nh.nicolas.hug@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug left review comments

Assignees
No one assigned
Labels
cla signed enhancement module: datasets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youcefouadjer @facebook-github-bot @NicolasHug