Add ROCm "support" #1765
Merged
Add ROCm "support" #1765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing this for a request from torchchat.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1765
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8906831 with merge base 82f8b77 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
No ciflow labels are configured for this repo. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1765 +/- ##
===========================================
- Coverage 69.33% 25.71% -43.62%
===========================================
Files 305 305
Lines 15892 15972 +80
===========================================
- Hits 11018 4107 -6911
- Misses 4874 11865 +6991 ☔ View full report in Codecov by Sentry. |
|
idek what's going on here |
SalmanMohammadi
approved these changes
Oct 9, 2024
And yet you are not ENTIRELY RESPONSIBLE if this goes wrong. glhf |
mori360
pushed a commit
to mori360/torchtune
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing this for a request from torchchat.
Closes #1771