Add a gaussian sampler #5487

pajotarthur · 2018-03-01T09:12:11Z

With @emited, adding a C and CUDA functions for a gaussian grid sampler, similar with the one described in https://openreview.net/pdf?id=SkZXoGZC- .

ezyang · 2018-03-01T17:02:49Z

@pajotarthur If you fix the merge conflicts I'll run this on CI for you.

ezyang · 2018-03-07T15:30:29Z

@pytorchbot test this please

zou3519 · 2018-03-12T19:55:54Z

@pytorchbot test this please

.jenkins/macos-build-test.sh

@@ -18,7 +18,7 @@ export MACOSX_DEPLOYMENT_TARGET=10.9
 export CXX=clang++
 export CC=clang
 # If we run too many parallel jobs, we will OOM
-export MAX_JOBS=2
+export MAX_JOBS=3


ezyang · 2018-03-13T14:03:48Z

What's going on with the pybind11 submodule update?

pajotarthur · 2018-03-13T15:48:40Z

I'm not really sure, I pulled from https://github.com/pybind/pybind11 manually by mistake a long time ago, I can checkout to the correct commit, but when I git submodule update, it reverts to the wrong one. Is there a workaround ? It doesn't seems to break anything though.

ezyang · 2018-03-23T18:23:48Z

@pajotarthur The main reason to not update it here is to let a pybind11 submodule be its own commit, so that's easier to notice if you're reading the commit stream.

An easy way to fix the problem is to "redo" your commit:

git reset HEAD~
git submodule update
git commit -C $oldcommithash

Another way is to manually checkout the submodule to the correct commit, and then do a git commit --amend.

ezyang · 2018-03-27T14:52:42Z

@pytorchbot test this please

ezyang · 2018-03-27T14:53:00Z

The submodule still looks updated to me

ezyang · 2018-03-27T14:53:29Z

BTW, you can check locally if you've done the fix properly by running git diff origin/master and seeing if the submodule update shows up there.

test/test_nn.py

-                grid_cpu = Variable(torch.randn(D, N, H, W, 3).transpose(0, 1), requires_grad=True)
-                out_cpu = F.grid_sample(input_cpu, grid_cpu, padding_mode=padding_mode)
-                self.assertTrue(out_cpu.size() == torch.Size([N, C, D, H, W]))
+            def test_cpu_against_cuda(N, C, D, H, W, padding_mode):


ezyang · 2018-04-16T18:49:28Z

@pajotarthur Did @emited do a math check on the two kernel implementations?

pajotarthur · 2018-04-17T12:14:36Z

Absolutely. Do you need the maths in writing ?

ezyang

Nope, that's good enough for me.

ezyang · 2018-04-26T03:11:53Z

Looks like there is some sort of submodule update disaster. https://stackoverflow.com/questions/7718780/how-to-undo-git-submodule-update?utm_medium=organic&utm_source=google_rich_qa&utm_campaign=google_rich_qa can tell you how to fix it (you'll have to find the correct hashes)

pajotarthur · 2018-04-27T11:41:15Z

I messed up my commit, I'll correct it soon.

ezyang · 2018-05-15T03:16:55Z

Needs rebasing :(

add gaussian sampler fix kernel_std add init

# Conflicts: # test/test_nn.py

# This is the 1st commit message: add gaussian sampler add gaussian sampler fix kernel_std add init # The commit message pytorch#2 will be skipped: # add init

ezyang · 2018-05-15T19:48:46Z

@pytorchbot retest this please

weiyangfb · 2018-08-21T18:29:32Z

@pajotarthur needs another rebasing now

stathius · 2019-06-05T00:42:15Z

Hey fellas, where is this standing right now?

ezyang

Unfortunately, due to our negligence, this PR has severely bitrotten. Probably the best thing to do is for someone to redo it in ATen (c.f. https://github.com/pytorch/pytorch/wiki/TH-to-ATen-porting-guide) and resubmit. Sorry :(

anderspapitto

.

Added gaussian mode for grid_sampler cuda

github-actions · 2022-03-23T21:03:05Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
Stale pull requests will automatically be closed 30 days after being marked Stale

facebook-github-bot · 2022-03-29T19:00:25Z

Hi @pajotarthur!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

github-actions · 2022-05-28T20:36:19Z

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

xming521 · 2023-09-24T08:01:06Z

Anything new?

ezyang reviewed Mar 13, 2018

View reviewed changes

.jenkins/macos-build-test.sh Outdated

@@ -18,7 +18,7 @@ export MACOSX_DEPLOYMENT_TARGET=10.9

export CXX=clang++

export CC=clang

# If we run too many parallel jobs, we will OOM

export MAX_JOBS=2

export MAX_JOBS=3

This comment was marked as off-topic.

Sign in to view

pajotarthur requested review from apaszke, colesbury, gchanan, soumith and zdevito as code owners April 6, 2018 14:33

ezyang reviewed Apr 16, 2018

View reviewed changes

ezyang approved these changes Apr 17, 2018

View reviewed changes

pajotarthur requested review from anderspapitto, bddppq, dzhulgakov, ebetica, goldsborough, houseroad, jamesr66a and smessmer as code owners May 15, 2018 12:26

pajotarthur reopened this May 15, 2018

pajotarthur added 8 commits May 15, 2018 17:31

add gaussian sampler

d71daff

correction pep8

2e42da9

fix kernel_std

811e890

add init

3df9a67

add gaussian sampler

e959781

add gaussian sampler fix kernel_std add init

Merge branch 'master' of https://github.com/pajotarthur/pytorch

8d9977e

# Conflicts: # test/test_nn.py

# This is a combination of 2 commits.

1d982d5

# This is the 1st commit message: add gaussian sampler add gaussian sampler fix kernel_std add init # The commit message pytorch#2 will be skipped: # add init

Merge branch 'master' of https://github.com/pajotarthur/pytorch

b494d06

Merge branch 'master' into master

f13f9b1

weiyangfb added the awaiting response (this tag is deprecated) This tag is deprecated while we figure out what to do with it label Aug 21, 2018

zdevito removed their request for review February 13, 2019 01:23

gchanan removed their request for review February 28, 2019 16:28

ezyang added the open source label Jun 5, 2019

ezyang requested changes Jun 7, 2019

View reviewed changes

zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 7, 2019

jamesr66a removed their request for review November 20, 2019 19:20

anderspapitto reviewed Oct 22, 2020

View reviewed changes

MengeTM pushed a commit to MengeTM/pytorch that referenced this pull request Feb 15, 2022

Trying to re-make stale code from pytorch#5487

b88e478

Added gaussian mode for grid_sampler cuda

github-actions bot added the Stale label Mar 23, 2022

github-actions bot removed the Stale label Mar 29, 2022

github-actions bot added the Stale label May 28, 2022

github-actions bot closed this Jun 27, 2022

Add a gaussian sampler #5487

Add a gaussian sampler #5487

Uh oh!

Conversation

pajotarthur commented Mar 1, 2018

Uh oh!

ezyang commented Mar 1, 2018

Uh oh!

ezyang commented Mar 7, 2018

Uh oh!

zou3519 commented Mar 12, 2018

Uh oh!

This comment was marked as off-topic.

Uh oh!

ezyang commented Mar 13, 2018

Uh oh!

pajotarthur commented Mar 13, 2018

Uh oh!

ezyang commented Mar 23, 2018

Uh oh!

ezyang commented Mar 27, 2018

Uh oh!

ezyang commented Mar 27, 2018

Uh oh!

ezyang commented Mar 27, 2018

Uh oh!

This comment was marked as off-topic.

Uh oh!

ezyang commented Apr 16, 2018

Uh oh!

pajotarthur commented Apr 17, 2018

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

ezyang commented Apr 26, 2018

Uh oh!

pajotarthur commented Apr 27, 2018

Uh oh!

ezyang commented May 15, 2018

Uh oh!

ezyang commented May 15, 2018

Uh oh!

weiyangfb commented Aug 21, 2018

Uh oh!

stathius commented Jun 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezyang left a comment

Choose a reason for hiding this comment

Uh oh!

anderspapitto left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 23, 2022

Uh oh!

facebook-github-bot commented Mar 29, 2022

Action Required

Process

Uh oh!

github-actions bot commented May 28, 2022

Uh oh!

xming521 commented Sep 24, 2023

Uh oh!

Uh oh!

stathius commented Jun 5, 2019 •

edited

Loading