Skip to content

Add py3.13t linux wheel build #137127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Add py3.13t linux wheel build #137127

wants to merge 8 commits into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Oct 1, 2024 •
edited
Loading

Builder PR required: pytorch/builder#2001
Test PR: #136490

@atalman atalman requested a review from a team as a code owner October 1, 2024 19:36
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 1, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/137127

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 2701600 with merge base a00f0d5 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

  • pull / linux-docs / build-docs-python-false (gh) (trunk failure)
    /opt/conda/envs/py_3.9/lib/python3.9/site-packages/sphinx/util/inspect.py:376: UserWarning: TypedStorage is deprecated. It will be removed in the future and UntypedStorage will be the only storage class. This should only matter to you if you are using storages directly. To access UntypedStorage directly, use tensor.untyped_storage() instead of tensor.storage()

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 1, 2024
albanD
albanD approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!
Lint needs fixing

@atalman
Copy link
Contributor Author

atalman commented Oct 2, 2024

@pytorchmergebot merge -f "all required tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@jovianjaison
Copy link
Contributor

@pytorchbot revert -m 'Sorry for reverting your changes but 2 jobs are failing' -c ignoredsignal

GH job link
GH job link
HUD commit link

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Oct 2, 2024
@pytorchmergebot
Revert "Add py3.13t linux wheel build (#137127)"
4559cdd 
This reverts commit 6b7adc1.

Reverted #137127 on behalf of https://github.com/jovianjaison due to Sorry for reverting your changes but 2 jobs are failing ([comment](#137127 (comment)))
@pytorchmergebot
Copy link
Collaborator

@atalman your PR has been successfully reverted.

@atalman atalman added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 2, 2024
@atalman
Copy link
Contributor Author

atalman commented Oct 2, 2024

@pytorchmergebot merge -i "lint is green and failing job is fixed"

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 2, 2024

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: lint is green and failing job is fixed

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick,close} ...

Try @pytorchbot --help for more info.

@atalman
Copy link
Contributor Author

atalman commented Oct 2, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_9-cuda12_4-test / test

Details for Dev Infra team Raised by workflow job

@atalman
Copy link
Contributor Author

atalman commented Oct 3, 2024

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@atalman
Copy link
Contributor Author

atalman commented Oct 3, 2024

@pytorchmergebot merge -f "all required jobs are passing"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@atalman atalman mentioned this pull request Dec 12, 2024
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albanD albanD albanD approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atalman @pytorchmergebot @jovianjaison @albanD