-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[MPS] Add missing dispatch to rshift.Tensor #135607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test plan: `python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"`
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135607
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0413f4b with merge base bf8d0e3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Attention! native_functions.yaml was changedIf you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info. Caused by: |
@pytorchbot merge -f "CI is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Missed it while working on pytorch#131813 Test plan: `python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"` Pull Request resolved: pytorch#135607 Approved by: https://github.com/manuelcandales
@pytorchbot cherry-pick -c critical --onto release/2.5 |
Missed it while working on #131813 Test plan: `python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"` Pull Request resolved: #135607 Approved by: https://github.com/manuelcandales (cherry picked from commit 3bf6be4)
Cherry picking #135607The cherry pick PR is at #137212 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
[MPS] Add missing dispatch to rshift.Tensor (#135607) Missed it while working on #131813 Test plan: `python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"` Pull Request resolved: #135607 Approved by: https://github.com/manuelcandales (cherry picked from commit 3bf6be4) Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Validated on final rc:
|
Missed it while working on #131813
Test plan:
python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"