Skip to content

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Sep 10, 2024

Missed it while working on #131813
Test plan: python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"

Test plan: `python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"`
@malfet malfet added this to the 2.5.0 milestone Sep 10, 2024
Copy link

pytorch-bot bot commented Sep 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/135607

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0413f4b with merge base bf8d0e3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added topic: bug fixes topic category release notes: mps Release notes category ciflow/mps Run MPS tests (subset of trunk) labels Sep 10, 2024
Copy link
Contributor

Attention! native_functions.yaml was changed

If you are adding a new function or defaulted argument to native_functions.yaml, you cannot use it from pre-existing Python frontend code until our FC window passes (two weeks). Split your PR into two PRs, one which adds the new C++ functionality, and one that makes use of it from Python, and land them two weeks apart. See https://github.com/pytorch/pytorch/wiki/PyTorch's-Python-Frontend-Backward-and-Forward-Compatibility-Policy#forwards-compatibility-fc for more info.


Caused by:

@malfet
Copy link
Contributor Author

malfet commented Sep 11, 2024

@pytorchbot merge -f "CI is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Sep 20, 2024
Missed it while working on pytorch#131813
Test plan: `python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"`

Pull Request resolved: pytorch#135607
Approved by: https://github.com/manuelcandales
@kit1980
Copy link
Contributor

kit1980 commented Oct 2, 2024

@pytorchbot cherry-pick -c critical --onto release/2.5

pytorchbot pushed a commit that referenced this pull request Oct 2, 2024
Missed it while working on #131813
Test plan: `python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"`

Pull Request resolved: #135607
Approved by: https://github.com/manuelcandales

(cherry picked from commit 3bf6be4)
@pytorchbot
Copy link
Collaborator

Cherry picking #135607

The cherry pick PR is at #137212 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

kit1980 pushed a commit that referenced this pull request Oct 2, 2024
[MPS] Add missing dispatch to rshift.Tensor (#135607)

Missed it while working on #131813
Test plan: `python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"`

Pull Request resolved: #135607
Approved by: https://github.com/manuelcandales

(cherry picked from commit 3bf6be4)

Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@atalman
Copy link
Contributor

atalman commented Oct 14, 2024

Validated on final rc:

python -c "import torch;print(torch.randint(100, 500, (64,), device='mps') >> torch.tensor([3,], device='mps'))"
tensor([49, 49, 34, 46, 27, 15, 57, 14, 44, 46, 53, 43, 33, 25, 49, 45, 18, 54,
        40, 36, 44, 32, 50, 19, 30, 57, 47, 53, 45, 28, 55, 26, 37, 53, 44, 62,
        16, 14, 42, 58, 46, 14, 61, 50, 26, 54, 17, 54, 61, 49, 51, 55, 48, 16,
        55, 59, 49, 61, 47, 23, 45, 52, 45, 27], device='mps:0')

@github-actions github-actions bot deleted the malfet-patch-15 branch November 14, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/mps Run MPS tests (subset of trunk) Merged release notes: mps Release notes category topic: bug fixes topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants