Avoid autocast deprecation warning in DataParallel (#130660) #134057

atalman · 2024-08-20T23:02:05Z

Co-authored-by: Yu, Guangye 106960996+guangyey@users.noreply.github.com
Pull Request resolved: #130660
Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o

Fixes pytorch#130659 Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com> Pull Request resolved: pytorch#130660 Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD

pytorch-bot · 2024-08-20T23:02:08Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134057

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 20 Unrelated Failures

As of commit 277b9f2 with merge base b66e3f0 ():

NEW FAILURE - The following job has failed:

pull / linux-focal-py3_8-clang9-xla / test (xla, 1, 1, linux.12xlarge) (gh)
test_repeat_truncated

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, linux.8xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 3, 3, linux.8xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 1, 5, linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 4, 5, linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 5, 5, linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (deploy, 1, 1, linux.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, linux.4xlarge.nvidia.gpu) (gh) (similar failure)
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 4, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 5, 5, linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
pull / linux-focal-cuda12.4-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, linux.4xlarge.nvidia.gpu) (gh) (similar failure)
pull / linux-focal-py3.11-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh) (disabled by #128551)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, linux.2xlarge) (gh) (disabled by #128551)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 3, linux.2xlarge) (gh) (disabled by #128551)
test_dataloader.py::TestDataLoader::test_segfault
pull / linux-jammy-py3.8-gcc11 / test (distributed, 1, 2, linux.2xlarge) (gh) (matched linux rule in flaky-rules.json)
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…30660) (pytorch#134057)" This reverts commit 4ebe5b7.

atalman requested review from albanD, jbschlosser and mikaylagawarecki as code owners August 20, 2024 23:02

pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Aug 20, 2024

atalman mentioned this pull request Aug 20, 2024

[v2.4.1] Release Tracker #132400

Closed

kit1980 approved these changes Aug 21, 2024

View reviewed changes

atalman merged commit 4ebe5b7 into pytorch:release/2.4 Aug 21, 2024
83 of 104 checks passed

atalman deleted the fix_cherry_pick branch August 21, 2024 16:43

atalman added a commit to atalman/pytorch that referenced this pull request Aug 22, 2024

Revert "Avoid autocast deprecation warning in DataParallel (pytorch#1…

a070ee0

…30660) (pytorch#134057)" This reverts commit 4ebe5b7.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Avoid autocast deprecation warning in DataParallel (#130660) #134057

Avoid autocast deprecation warning in DataParallel (#130660) #134057

Uh oh!

atalman commented Aug 20, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Aug 20, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Avoid autocast deprecation warning in DataParallel (#130660) #134057

Avoid autocast deprecation warning in DataParallel (#130660) #134057

Uh oh!

Conversation

atalman commented Aug 20, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/134057

❌ 1 New Failure, 20 Unrelated Failures

Uh oh!

Uh oh!

Uh oh!

atalman commented Aug 20, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Aug 20, 2024 •

edited

Loading