Add xpu_cmake_macros.h to xpu build #132847
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/132847
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 88f473d with merge base c184ac0 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Overall, it looks good to me. But I think the PR description is not the motivation. We need to describe what the changes serve for. If it is an issue to support extension mechanism, I'd prefer to submit an issue and link to the issue number. |
EikanWang
approved these changes
Aug 8, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot cherry-pick --onto release/2.4 -c critical --fixes #132971 |
pytorchbot
pushed a commit
that referenced
this pull request
Aug 16, 2024
# Motivation fix #132971 Pull Request resolved: #132847 Approved by: https://github.com/EikanWang (cherry picked from commit 9c5e0d4)
Cherry picking #132847The cherry pick PR is at #133649 and it is linked with issue #132971. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
dvrogozh
added a commit
to dvrogozh/optimum-quanto
that referenced
this pull request
Aug 16, 2024
This commit implements xpu extension with unpack kernels written in sycl. Pytorch XPU backend provides hw acceleration on Intel GPUs. At the moment Meteor Lake (MTL) and Data Center Max (PVC) are supported. Provided sycl kernel was converted from existing cuda kernel. $ python bench/kernels/benchmark.py --it 1000 unpack_2bit[xpu]: python = 0.177 ms, ext = 0.033 ms, ratio = 5.4x unpack_4bit[xpu]: python = 0.085 ms, ext = 0.026 ms, ratio = 3.3x note: without extension ratio is 0.8x. At the moment there are few not implemented features for xpu backend which affect implementation. These are: * pytorch/pytorch#127929 * Some memory ops not supported by xpu backend * WA applied: calling these ops is commented out * pytorch/pytorch#131840 * elapsed_time is not supported by XPUEvent * WA applied: calling these ops is commented out (CPU e2e time is measured) * pytorch/pytorch#132947 * Some aten ops are not implemented with xpu backend falling back to cpu * WA required: set PYTORCH_ENABLE_XPU_FALLBACK=1 on cmdline Requires: pytorch/pytorch#132847 Requires: pytorch/pytorch#132945 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
atalman
pushed a commit
that referenced
this pull request
Aug 21, 2024
Add xpu_cmake_macros.h to xpu build (#132847) # Motivation fix #132971 Pull Request resolved: #132847 Approved by: https://github.com/EikanWang (cherry picked from commit 9c5e0d4) Co-authored-by: Yu, Guangye <guangye.yu@intel.com>
dvrogozh
added a commit
to dvrogozh/pytorch
that referenced
this pull request
Sep 24, 2024
Fixes: pytorch#132944 This patch adds support for sycl kernels build via torch.utils.cpp_extension.load API. Files having .sycl extension are considered to have sycl kernels and are compiled with icpx (dpc++ sycl compiler from Intel). Files with other extensions, .cpp, .cu, are handled as before. API supports building sycl along with other file types into single extension. By default SYCL kernels are compiled for all Intel GPU devices for which pytorch native aten SYCL kernels are compiled. At the moment "pvc,xe-lpg". This behavior can be overriden by setting TORCH_XPU_ARCH_LIST environment variables to the comma separated list of desired devices to compile for. Requires: pytorch#132847 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
dvrogozh
added a commit
to dvrogozh/pytorch
that referenced
this pull request
Jan 10, 2025
Fixes: pytorch#132944 This patch adds support for sycl kernels build via torch.utils.cpp_extension.load API. Files having .sycl extension are considered to have sycl kernels and are compiled with icpx (dpc++ sycl compiler from Intel). Files with other extensions, .cpp, .cu, are handled as before. API supports building sycl along with other file types into single extension. By default SYCL kernels are compiled for all Intel GPU devices for which pytorch native aten SYCL kernels are compiled. At the moment "pvc,xe-lpg". This behavior can be overriden by setting TORCH_XPU_ARCH_LIST environment variables to the comma separated list of desired devices to compile for. Requires: pytorch#132847 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
pytorch-bot bot
pushed a commit
that referenced
this pull request
Jan 17, 2025
Fixes: #132944 This patch adds support for sycl kernels build via torch.utils.cpp_extension.load API. Files having .sycl extension are considered to have sycl kernels and are compiled with icpx (dpc++ sycl compiler from Intel). Files with other extensions, .cpp, .cu, are handled as before. API supports building sycl along with other file types into single extension. By default SYCL kernels are compiled for all Intel GPU devices for which pytorch native aten SYCL kernels are compiled. At the moment "pvc,xe-lpg". This behavior can be overriden by setting TORCH_XPU_ARCH_LIST environment variables to the comma separated list of desired devices to compile for. Requires: #132847 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
pytorch-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
Fixes: #132944 This patch adds support for sycl kernels build via torch.utils.cpp_extension.load API. Files having .sycl extension are considered to have sycl kernels and are compiled with icpx (dpc++ sycl compiler from Intel). Files with other extensions, .cpp, .cu, are handled as before. API supports building sycl along with other file types into single extension. By default SYCL kernels are compiled for all Intel GPU devices for which pytorch native aten SYCL kernels are compiled. At the moment "pvc,xe-lpg". This behavior can be overriden by setting TORCH_XPU_ARCH_LIST environment variables to the comma separated list of desired devices to compile for. Requires: #132847 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
pytorch-bot bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
Fixes: #132944 This patch adds support for sycl kernels build via torch.utils.cpp_extension.load API. Files having .sycl extension are considered to have sycl kernels and are compiled with icpx (dpc++ sycl compiler from Intel). Files with other extensions, .cpp, .cu, are handled as before. API supports building sycl along with other file types into single extension. By default SYCL kernels are compiled for all Intel GPU devices for which pytorch native aten SYCL kernels are compiled. At the moment "pvc,xe-lpg". This behavior can be overriden by setting TORCH_XPU_ARCH_LIST environment variables to the comma separated list of desired devices to compile for. Requires: #132847 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2025
Fixes: #132944 This patch adds support for sycl kernels build via torch.utils.cpp_extension.load API. Files having .sycl extension are considered to have sycl kernels and are compiled with icpx (dpc++ sycl compiler from Intel). Files with other extensions, .cpp, .cu, are handled as before. API supports building sycl along with other file types into single extension. By default SYCL kernels are compiled for all Intel GPU devices for which pytorch native aten SYCL kernels are compiled. At the moment "pvc,xe-lpg". This behavior can be overriden by setting TORCH_XPU_ARCH_LIST environment variables to the comma separated list of desired devices to compile for. Requires: #132847 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 15, 2025
Fixes: #132944 This patch adds support for sycl kernels build via torch.utils.cpp_extension.load API. Files having .sycl extension are considered to have sycl kernels and are compiled with icpx (dpc++ sycl compiler from Intel). Files with other extensions, .cpp, .cu, are handled as before. API supports building sycl along with other file types into single extension. By default SYCL kernels are compiled for all Intel GPU devices for which pytorch native aten SYCL kernels are compiled. At the moment "pvc,xe-lpg". This behavior can be overriden by setting TORCH_XPU_ARCH_LIST environment variables to the comma separated list of desired devices to compile for. Requires: #132847 Signed-off-by: Dmitry Rogozhkin <dmitry.v.rogozhkin@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
fix #132971
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10