Skip to content

Avoid autocast deprecation warning in DataParallel #130660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Avoid autocast deprecation warning in DataParallel #130660

wants to merge 4 commits into from

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 13, 2024 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130660

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit 3e1db67 with merge base c1e7e40 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Jul 13, 2024
@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 13, 2024
guangyey
guangyey reviewed Jul 16, 2024
View reviewed changes
@guangyey guangyey mentioned this pull request Jul 16, 2024
Closed
@awaelchli @guangyey
Update torch/nn/parallel/parallel_apply.py
a16919d 
Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com>
awaelchli
awaelchli commented Jul 16, 2024
View reviewed changes
@fegin fegin added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jul 16, 2024
@awaelchli
Copy link
Contributor Author

awaelchli commented Jul 17, 2024 •
edited
Loading

Some test workflows failed, but look unrelated. How should I proceed?

@guangyey
Copy link
Collaborator

Unrelated failures.
@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@guangyey guangyey added the topic: not user facing topic category label Jul 17, 2024
@guangyey
Copy link
Collaborator

Unrelated failures.
@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, linux.2xlarge), periodic / win-vs2019-cuda11.8-py3 / test (default, 3, 4, windows.g5.4xlarge.nvidia.gpu), periodic / linux-focal-cuda11.8-py3.10-gcc9-debug / test (default, 1, 5, linux.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@awaelchli awaelchli deleted the bugfix-autocast-warning branch July 17, 2024 09:07
mlazos pushed a commit that referenced this pull request Jul 18, 2024
@awaelchli @guangyey @mlazos
Avoid autocast deprecation warning in DataParallel (#130660)
3f524bd 
Fixes #130659

Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com>
Pull Request resolved: #130660
Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD
DiweiSun pushed a commit to DiweiSun/pytorch that referenced this pull request Jul 22, 2024
@awaelchli @guangyey @DiweiSun
Avoid autocast deprecation warning in DataParallel (pytorch#130660)
d778904 
Fixes pytorch#130659

Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com>
Pull Request resolved: pytorch#130660
Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD
xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@awaelchli @guangyey @xuhancn
Avoid autocast deprecation warning in DataParallel (pytorch#130660)
eaf33f9 
Fixes pytorch#130659

Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com>
Pull Request resolved: pytorch#130660
Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD
@atalman
Copy link
Contributor

atalman commented Aug 15, 2024

@pytorchbot cherry-pick --onto release/2.4 -c critical --fixes #130659

pytorchbot pushed a commit that referenced this pull request Aug 15, 2024
@awaelchli @pytorchbot
Avoid autocast deprecation warning in DataParallel (#130660)
ad96840 
Fixes #130659

Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com>
Pull Request resolved: #130660
Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD

(cherry picked from commit bb62e9d)
@pytorchbot
Copy link
Collaborator

Cherry picking #130660

The cherry pick PR is at #133591 and it is linked with issue #130659. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Aug 15, 2024
Closed
atalman pushed a commit to atalman/pytorch that referenced this pull request Aug 20, 2024
@awaelchli @guangyey @atalman
Avoid autocast deprecation warning in DataParallel (pytorch#130660)
277b9f2 
Fixes pytorch#130659

Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com>
Pull Request resolved: pytorch#130660
Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD
@atalman atalman mentioned this pull request Aug 20, 2024
Merged
atalman added a commit that referenced this pull request Aug 21, 2024
@atalman @awaelchli
Avoid autocast deprecation warning in DataParallel (#130660) (#134057)
4ebe5b7 
Fixes #130659

Co-authored-by: Yu, Guangye <106960996+guangyey@users.noreply.github.com>
Pull Request resolved: #130660
Approved by: https://github.com/guangyey, https://github.com/fegin, https://github.com/albanD

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
atalman added a commit to atalman/pytorch that referenced this pull request Aug 22, 2024
@atalman
Revert "Avoid autocast deprecation warning in DataParallel (pytorch#1…
a070ee0 
…30660) (pytorch#134057)"

This reverts commit 4ebe5b7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fegin fegin fegin approved these changes

@albanD albanD albanD approved these changes

@guangyey guangyey guangyey approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser jbschlosser is a code owner

@mikaylagawarecki mikaylagawarecki Awaiting requested review from mikaylagawarecki mikaylagawarecki is a code owner

Assignees
No one assigned
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal uses of torch.cuda.amp.autocast raise FutureWarnings
8 participants
@awaelchli @guangyey @pytorchmergebot @atalman @pytorchbot @fegin @albanD @bdhirsh