Skip to content

Use irange to avoid -Wsign-compare errors #130388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Use irange to avoid -Wsign-compare errors #130388

wants to merge 3 commits into from

Conversation

izaitsevfb
Copy link
Contributor

Fixes meta-internal errors after importing #128753

(see D59498679)

fbcode/caffe2/aten/src/ATen/Context.cpp:286:34: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
      for (auto index = 0; index < at::getNumGPUs(); index++) {
                           ~~~~~ ^ ~~~~~~~~~~~~~~~~
1 error generated.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/130388

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 2f43b04 with merge base ae73489 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@izaitsevfb izaitsevfb requested a review from a team July 9, 2024 22:38
Skylion007
Skylion007 reviewed Jul 10, 2024
View reviewed changes
@izaitsevfb
Copy link
Contributor Author

@pytorchbot rebase

@izaitsevfb izaitsevfb changed the title Add explicit static_cast to avoid -Wsign-compare errors Add explicit type to avoid -Wsign-compare errors Jul 10, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

izaitsevfb and others added 2 commits July 10, 2024 21:09
@pytorchmergebot
Copy link
Collaborator

Successfully rebased get-num-gpus-fix-signed-comp onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout get-num-gpus-fix-signed-comp && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the get-num-gpus-fix-signed-comp branch from c70c48c to a1826cd Compare July 10, 2024 21:09
malfet
malfet reviewed Jul 10, 2024
View reviewed changes
@izaitsevfb @malfet
Update aten/src/ATen/Context.cpp
2f43b04 
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
@izaitsevfb izaitsevfb changed the title Add explicit type to avoid -Wsign-compare errors Replace loop with irange to avoid -Wsign-compare errors Jul 10, 2024
@izaitsevfb izaitsevfb changed the title Replace loop with irange to avoid -Wsign-compare errors Use irange to avoid -Wsign-compare errors Jul 10, 2024
@izaitsevfb
Copy link
Contributor Author

@pytorchbot merge -f 'lint passed'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

xuhancn pushed a commit to xuhancn/pytorch that referenced this pull request Jul 25, 2024
@izaitsevfb @Skylion007
@malfet @xuhancn
Use irange to avoid -Wsign-compare errors (pytorch#130388)
6698c65 
Fixes meta-internal errors after importing pytorch#128753

(see [D59498679](https://www.internalfb.com/diff/D59498679))
```
fbcode/caffe2/aten/src/ATen/Context.cpp:286:34: error: comparison of integers of different signs: 'int' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
      for (auto index = 0; index < at::getNumGPUs(); index++) {
                           ~~~~~ ^ ~~~~~~~~~~~~~~~~
1 error generated.
```
Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com>
Co-authored-by: Nikita Shulga <2453524+malfet@users.noreply.github.com>
Pull Request resolved: pytorch#130388
Approved by: https://github.com/Skylion007, https://github.com/malfet
@github-actions github-actions bot deleted the get-num-gpus-fix-signed-comp branch August 10, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

Assignees
No one assigned
Labels
Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@izaitsevfb @pytorchmergebot @Skylion007 @malfet