Skip to content

Conversation

eqy
Copy link
Collaborator

@eqy eqy commented Jun 6, 2024

#120006 only very recently unskipped this test 3 days ago so we don't consider it a blocker for cuDNNv9 for now

CC @atalman

cc @csarofeen @ptrblck @xwang233 @jerryzh168 @jianyuh @raghuramank100 @jamesr66a @vkuzo @jgong5 @Xia-Weiwen @leslie-fang-intel @msaroufim

@eqy eqy added module: cudnn Related to torch.backends.cudnn, and CuDNN support oncall: quantization Quantization support in PyTorch module: cuda Related to torch.cuda, and CUDA support in general open source topic: not user facing topic category labels Jun 6, 2024
@eqy eqy requested a review from jerryzh168 as a code owner June 6, 2024 21:23
Copy link

pytorch-bot bot commented Jun 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128166

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit fee64bc with merge base 9554300 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: quantization release notes category label Jun 6, 2024
@eqy eqy added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 6, 2024
Copy link
Collaborator

@nWEIdia nWEIdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@atalman
Copy link
Contributor

atalman commented Jun 6, 2024

Lets create tracking issue to re-enable this test.

@atalman
Copy link
Contributor

atalman commented Jun 6, 2024

@pytorchmergebot merge -f "lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Jun 11, 2024
…NN quantization backend (#128177)

Similar in spirit to #125790, hopefully addresses failures seen for cuDNN 9.1 upgrade: ##128166

CC @nWEIdia @atalman

Pull Request resolved: #128177
Approved by: https://github.com/nWEIdia, https://github.com/Skylion007
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
pytorch#120006 only very recently unskipped this test 3 days ago so we don't consider it a blocker for cuDNNv9 for now

CC @atalman

Pull Request resolved: pytorch#128166
Approved by: https://github.com/atalman, https://github.com/nWEIdia
TharinduRusira pushed a commit to TharinduRusira/pytorch that referenced this pull request Jun 14, 2024
…NN quantization backend (pytorch#128177)

Similar in spirit to pytorch#125790, hopefully addresses failures seen for cuDNN 9.1 upgrade: #pytorch#128166

CC @nWEIdia @atalman

Pull Request resolved: pytorch#128177
Approved by: https://github.com/nWEIdia, https://github.com/Skylion007
ignaciobartol pushed a commit to ignaciobartol/pytorch that referenced this pull request Jun 14, 2024
…NN quantization backend (pytorch#128177)

Similar in spirit to pytorch#125790, hopefully addresses failures seen for cuDNN 9.1 upgrade: #pytorch#128166

CC @nWEIdia @atalman

Pull Request resolved: pytorch#128177
Approved by: https://github.com/nWEIdia, https://github.com/Skylion007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: cuda Related to torch.cuda, and CUDA support in general module: cudnn Related to torch.backends.cudnn, and CuDNN support oncall: quantization Quantization support in PyTorch open source release notes: quantization release notes category topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants