[DSD] Add a test to verify FSDP lazy initialization case #127069
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127069
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 1126ab5 with merge base c921c5c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced May 24, 2024
wz337
approved these changes
May 24, 2024
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
fegin
added a commit
that referenced
this pull request
May 24, 2024
Summary: Distributed state_dict should not error out because the `model.state_dict()` will trigger FSDP to initialize. Pull Request resolved: #127069 Approved by: https://github.com/wz337
pytorchmergebot
pushed a commit
that referenced
this pull request
May 27, 2024
Summary: Distributed state_dict should not error out because the `model.state_dict()` will trigger FSDP to initialize. Pull Request resolved: #127069 Approved by: https://github.com/wz337
atalman
added a commit
that referenced
this pull request
May 27, 2024
…127130) * [DSD] Add a test to verify FSDP lazy initialization case (#127069) Summary: Distributed state_dict should not error out because the `model.state_dict()` will trigger FSDP to initialize. Pull Request resolved: #127069 Approved by: https://github.com/wz337 * Add missing import get_optimizer_state_dict --------- Co-authored-by: Andrey Talman <atalman@fb.com>
titaiwangms
pushed a commit
to titaiwangms/pytorch
that referenced
this pull request
May 28, 2024
) Summary: Distributed state_dict should not error out because the `model.state_dict()` will trigger FSDP to initialize. Pull Request resolved: pytorch#127069 Approved by: https://github.com/wz337
bigfootjon
pushed a commit
that referenced
this pull request
May 28, 2024
Summary: Distributed state_dict should not error out because the `model.state_dict()` will trigger FSDP to initialize. Pull Request resolved: #127069 Approved by: https://github.com/wz337 (cherry picked from commit b0871f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Distributed state_dict should not error out because the
model.state_dict()will trigger FSDP to initialize.cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k @LucasLLC