Skip to content

Forbid subclassing _TensorBase directly #125558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Forbid subclassing _TensorBase directly #125558

wants to merge 2 commits into from

Conversation

albanD
Copy link
Collaborator

@albanD albanD commented May 5, 2024 •
edited
Loading

As per title.
This ensures that all the places where we assume the method defined in _tensor.py do exist.

BC-Breaking: This is bc-breaking as the user cannot subclass this private class anymore.
You should replace any use of _TensorBase to Tensor.

@albanD albanD requested a review from ezyang May 5, 2024 23:26
@albanD albanD requested a review from soulitzer as a code owner May 5, 2024 23:26
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 5, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125558

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 12ae25a with merge base a1a22a2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@albanD albanD added topic: bc breaking topic category module: python frontend For issues relating to PyTorch's Python frontend release notes: python_frontend python frontend release notes category and removed module: python frontend For issues relating to PyTorch's Python frontend labels May 6, 2024
ezyang
ezyang approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okey dokey

@albanD
Copy link
Collaborator Author

albanD commented May 8, 2024

@pytorchbot merge -r

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 8, 2024
@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased forbid_tensor_base_subclass onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout forbid_tensor_base_subclass && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the forbid_tensor_base_subclass branch from c5b6c04 to 12ae25a Compare May 8, 2024 16:47
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@soulitzer soulitzer Awaiting requested review from soulitzer soulitzer is a code owner

Assignees
No one assigned
Labels
ci-td-distributed ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: python_frontend python frontend release notes category topic: bc breaking topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albanD @pytorchmergebot @ezyang