[DeviceMesh] Added DeviceMesh.from_group()
#124787
Closed
+92
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Apr 23, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/124787
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0f814db with merge base c82fcb7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wanchaol
approved these changes
Apr 24, 2024
| @@ -434,6 +440,23 @@ def get_group( | |||
| ) | |||
| return dim_groups | |||
|
|
|||
| @staticmethod | |||
| def from_group(group: ProcessGroup, device_type: str) -> "DeviceMesh": | |||
There was a problem hiding this comment.
can we add some documentation?
Also I am thinking how we should support multi-dim from group, i.e. HSDP shard, replicate group to pass in to construct a DeviceMesh, I guess the group argument would likely need to be Union[ProcessGroup, List[ProcessGroup]]
There was a problem hiding this comment.
Also I am thinking how we should support multi-dim from group, i.e. HSDP shard, replicate group to pass in to construct a DeviceMesh, I guess the group argument would likely need to be Union[ProcessGroup, List[ProcessGroup]]
This makes sense to me. Shall we expand the API later when we need it in a separate PR?
There was a problem hiding this comment.
yeah we don't need to do it in this PR as it's BC compatible if later we expand the API
We need `DeviceMesh.from_group()` to allow FSDP2 to interoperate with distributed libraries that do not use `DeviceMesh` for all parallelisms. cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
DeviceMesh.from_group() prototypeDeviceMesh.from_group()
This PR adds a `DeviceMesh.from_group()` static method to convert an existing process group to a device mesh. Motivation: We need `DeviceMesh.from_group()` to allow FSDP2 to interoperate with distributed libraries that do not use `DeviceMesh` for all parallelisms. cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
|
cc: @wanchaol I added some documentation and a simple unit test in |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
alat-rights
pushed a commit
to alat-rights/pytorch
that referenced
this pull request
Apr 26, 2024
This PR adds a `DeviceMesh.from_group()` static method to convert an existing process group to a device mesh. Motivation: We need `DeviceMesh.from_group()` to allow FSDP2 to interoperate with distributed libraries that do not use `DeviceMesh` for all parallelisms. Pull Request resolved: pytorch#124787 Approved by: https://github.com/wanchaol ghstack dependencies: pytorch#124651, pytorch#124741, pytorch#124767, pytorch#124768, pytorch#124780
pytorchmergebot
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR renames the `FSDP` class to `FSDPModule`. This is a BC breaking change. The rationale is that `FSDPModule` is more descriptive since `fully_shard` is a module-level API (applied to a `module` arg), so the `FSDP` class will always correspond to a module. Also, users commonly import `FullyShardedDataParallel` as `FSDP`, so this can help avoid some name conflict in some cases. Pull Request resolved: #124955 Approved by: https://github.com/wanchaol, https://github.com/wconstab ghstack dependencies: #124651, #124741, #124767, #124768, #124780, #124787
This was referenced Apr 29, 2024
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
This PR adds a `DeviceMesh.from_group()` static method to convert an existing process group to a device mesh. Motivation: We need `DeviceMesh.from_group()` to allow FSDP2 to interoperate with distributed libraries that do not use `DeviceMesh` for all parallelisms. Pull Request resolved: #124787 Approved by: https://github.com/wanchaol ghstack dependencies: #124651, #124741, #124767, #124768, #124780
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
This PR renames the `FSDP` class to `FSDPModule`. This is a BC breaking change. The rationale is that `FSDPModule` is more descriptive since `fully_shard` is a module-level API (applied to a `module` arg), so the `FSDP` class will always correspond to a module. Also, users commonly import `FullyShardedDataParallel` as `FSDP`, so this can help avoid some name conflict in some cases. Pull Request resolved: #124955 Approved by: https://github.com/wanchaol, https://github.com/wconstab ghstack dependencies: #124651, #124741, #124767, #124768, #124780, #124787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
DeviceMesh.from_group()#124787.to(cpu)#124768This PR adds a
DeviceMesh.from_group()static method to convert an existing process group to a device mesh.Motivation: We need
DeviceMesh.from_group()to allow FSDP2 to interoperate with distributed libraries that do not useDeviceMeshfor all parallelisms.cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @penguinwu @fegin @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @d4l3k