[nit][DCP][DSD] Remove variables not being used in test_state_dict.py #121204 #121773
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121773
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b82e6ee with merge base 522d972 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: .github/workflows/trunk.yml / macos-12-py3-arm64-mps / test (mps, 1, 1, macos-m1-stable) Details for Dev Infra teamRaised by workflow job |
|
@pytorchmergebot merge -i |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Thanks @fegin for removing the fsdp root module check in DCP to unblock test updates. #121544 This PR adds "optimzer_class" as a kwarg for the subtests of the following tests to add AdamW as an option. - test_fsdp - test_compiled_fsdp - test_fsdp2 - test_ddp - test_fsdp_ddp - test_cpu_offload_full_state_dict In addition, we temporarily remove the two _verify_osd_by_load in _test_save_load, as state dict loading seems affect parameters. Creating an issue #121186 to keep track. Pull Request resolved: #121774 Approved by: https://github.com/Skylion007 ghstack dependencies: #121773
Stack from ghstack (oldest at bottom):
Replacing #121204
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @tianyu-l @wconstab @yf225 @chauhang @LucasLLC