[nit][DCP][DSD] Remove Unused Variables in test_state_dict.py #121204

wz337 · 2024-03-05T06:27:24Z

Stack from ghstack (oldest at bottom):

-> [nit][DCP][DSD] Remove Unused Variables in test_state_dict.py #121204

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @fegin @XilunWu @wanchaol @fduwjj @tianyu-l @wconstab @yf225 @chauhang @LucasLLC

[ghstack-poisoned]

ghstack-source-id: 76ade4f Pull Request resolved: #121204

pytorch-bot · 2024-03-05T06:27:30Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121204

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 8c0777f with merge base d7a5e59 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

.github/workflows/generated-linux-binary-libtorch-cxx11-abi-main.yml (gh)
.github/workflows/generated-linux-binary-libtorch-pre-cxx11-main.yml (gh)
.github/workflows/generated-linux-binary-manywheel-main.yml (gh)
.github/workflows/trunk.yml (gh)
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu) (gh)
distributed/checkpoint/test_state_dict.py::TestStateDict::test_compiled_fsdp

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fegin

Why does this change cause FSDP compilation state_dict error? Is the error pre-existed?

wz337 · 2024-03-05T18:37:33Z

Why does this change cause FSDP compilation state_dict error? Is the error pre-existed?

Seems like so. I am having this error locally and I don't think it's related to the change, so I push just push these two-line changes definitely unrelated to double check.

….py" cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj tianyu-l wconstab yf225 chauhang LucasLLC [ghstack-poisoned]

ghstack-source-id: 9fa63ee Pull Request resolved: #121204

Skylion007 · 2024-03-06T18:11:59Z

test/distributed/checkpoint/test_state_dict.py

@@ -106,9 +106,6 @@ def _test_save_load(
        # Then finally we can call set_state_dict().
        if not isinstance(dist_optim, list):
            dist_optim = [dist_optim]
-        curr_dist_msd, curr_dist_osd = get_state_dict(


Hmm, should have been caught by F841

….py" cc mrshenli pritamdamania87 zhaojuanmao satgera rohan-varma gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj tianyu-l wconstab yf225 chauhang LucasLLC [ghstack-poisoned]

ghstack-source-id: 9b53e05 Pull Request resolved: #121204

wz337 · 2024-03-07T22:48:57Z

@pytorchmergebot merge -i

pytorchmergebot · 2024-03-07T22:50:49Z

Merge started

Your change will be merged while ignoring the following 1 checks: pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

huydhn · 2024-03-08T19:07:04Z

@pytorchbot revert -m 'Sorry for reverting your PR, but the failure looks legit' -c ignoredsignal

pytorchmergebot · 2024-03-08T19:08:40Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2024-03-08T19:08:53Z

@wz337 your PR has been successfully reverted.

…#121204)" This reverts commit 4186c36. Reverted #121204 on behalf of https://github.com/huydhn due to Sorry for reverting your PR, but the failure looks legit ([comment](#121204 (comment)))

wz337 · 2024-03-12T20:50:33Z

@pytorchmergebot rebase

pytorchmergebot · 2024-03-12T20:52:05Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2024-03-12T20:52:09Z

Rebase failed due to

Aborting rebase because rebasing the branch resulted in the same sha as the target branch.
This usually happens because the PR has already been merged.  Please rebase locally and push.

Raised by https://github.com/pytorch/pytorch/actions/runs/8255571895

…121204 (#121773) Replacing #121204 Pull Request resolved: #121773 Approved by: https://github.com/Skylion007

remove unused variables

b23984e

[ghstack-poisoned]

pytorch-bot bot added the topic: not user facing topic category label Mar 5, 2024

wz337 added a commit that referenced this pull request Mar 5, 2024

remove unused variables

a84c16c

ghstack-source-id: 76ade4f Pull Request resolved: #121204

github-actions bot added oncall: distributed Add this issue/PR to distributed oncall triage queue module: distributed_checkpoint labels Mar 5, 2024

wz337 changed the title ~~remove unused variables~~ [nit][DCP][DSD] Remove Unused Variables in test_state_dict.py Mar 5, 2024

wz337 requested a review from fegin March 5, 2024 06:28

fegin reviewed Mar 5, 2024

View reviewed changes

wz337 added a commit that referenced this pull request Mar 5, 2024

remove unused variables

24b210a

ghstack-source-id: 9fa63ee Pull Request resolved: #121204

Skylion007 reviewed Mar 6, 2024

View reviewed changes

Skylion007 approved these changes Mar 6, 2024

View reviewed changes

wz337 added a commit that referenced this pull request Mar 7, 2024

remove unused variables

e45c6e1

ghstack-source-id: 9b53e05 Pull Request resolved: #121204

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 7, 2024

pytorchmergebot added the merging label Mar 7, 2024

pytorchmergebot added the Merged label Mar 8, 2024

pytorchmergebot closed this in 4186c36 Mar 8, 2024

pytorchmergebot removed the merging label Mar 8, 2024

pytorchmergebot added the Reverted label Mar 8, 2024

pytorchmergebot reopened this Mar 8, 2024

LucasLLC mentioned this pull request Mar 8, 2024

[DCP] test_state_dict.test_fsdp is failing on unrelated tests in CI. #121543

Open

wz337 closed this Mar 12, 2024

wz337 mentioned this pull request Mar 13, 2024

[nit][DCP][DSD] Remove variables not being used in test_state_dict.py #121204 #121773

Closed

pytorchmergebot pushed a commit that referenced this pull request Mar 13, 2024

[nit][DCP][DSD] Remove variables not being used in test_state_dict.py #…

5986552

…121204 (#121773) Replacing #121204 Pull Request resolved: #121773 Approved by: https://github.com/Skylion007

github-actions bot deleted the gh/wz337/4/head branch April 12, 2024 01:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[nit][DCP][DSD] Remove Unused Variables in test_state_dict.py #121204

[nit][DCP][DSD] Remove Unused Variables in test_state_dict.py #121204

Uh oh!

wz337 commented Mar 5, 2024 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Mar 5, 2024 •

edited

Loading

Uh oh!

fegin left a comment

Uh oh!

wz337 commented Mar 5, 2024

Uh oh!

Skylion007 Mar 6, 2024

Uh oh!

wz337 commented Mar 7, 2024

Uh oh!

pytorchmergebot commented Mar 7, 2024

Uh oh!

huydhn commented Mar 8, 2024

Uh oh!

pytorchmergebot commented Mar 8, 2024

Uh oh!

pytorchmergebot commented Mar 8, 2024

Uh oh!

wz337 commented Mar 12, 2024

Uh oh!

pytorchmergebot commented Mar 12, 2024

Uh oh!

pytorchmergebot commented Mar 12, 2024

Uh oh!

Uh oh!

[nit][DCP][DSD] Remove Unused Variables in test_state_dict.py #121204

[nit][DCP][DSD] Remove Unused Variables in test_state_dict.py #121204

Uh oh!

Conversation

wz337 commented Mar 5, 2024 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121204

✅ You can merge normally! (5 Unrelated Failures)

Uh oh!

fegin left a comment

Choose a reason for hiding this comment

Uh oh!

wz337 commented Mar 5, 2024

Uh oh!

Skylion007 Mar 6, 2024

Choose a reason for hiding this comment

Uh oh!

wz337 commented Mar 7, 2024

Uh oh!

pytorchmergebot commented Mar 7, 2024

Merge started

Uh oh!

huydhn commented Mar 8, 2024

Uh oh!

pytorchmergebot commented Mar 8, 2024

Uh oh!

pytorchmergebot commented Mar 8, 2024

Uh oh!

wz337 commented Mar 12, 2024

Uh oh!

pytorchmergebot commented Mar 12, 2024

Uh oh!

pytorchmergebot commented Mar 12, 2024

Uh oh!

Uh oh!

wz337 commented Mar 5, 2024 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 5, 2024 •

edited

Loading