Skip to content

Conversation

snadampal
Copy link
Collaborator

@snadampal snadampal commented Mar 6, 2024

Triggered by ciflow/linux-aarch64 and runs only test_modules, test_mkldnn, test_mkldnn_fusion and test_openmp as test for now.
TODOS:

  • Enable sscache for fast CI
  • Extend to a more reasonable test coverage

@snadampal snadampal requested a review from a team as a code owner March 6, 2024 01:07
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 6, 2024
Copy link

pytorch-bot bot commented Mar 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121284

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 4 Unrelated Failures

As of commit 49517c3 with merge base a8574a9 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 6, 2024
@snadampal snadampal requested a review from jeffdaily as a code owner March 9, 2024 00:44
@snadampal
Copy link
Collaborator Author

rebased the PR to the latest PyTorch to get tlparse upgrade (to 0.3.7) changes.

@atalman
Copy link
Contributor

atalman commented Apr 22, 2024

@snadampal could you please take a look at failing lint jobs ?

@malfet
Copy link
Contributor

malfet commented Apr 22, 2024

Had somebody had a chance to figure out what is amiss with sccache?

@snadampal
Copy link
Collaborator Author

Hi @malfet , you'd opened this PR for building sccache from sources, right
#121323

@snadampal
Copy link
Collaborator Author

all CI except the Lint related passed.
@atalman , @malfet , can you please take a look and merge it it looks good to you.

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@snadampal your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Apr 30, 2024
This reverts commit 32cf04c.

Reverted #121284 on behalf of https://github.com/malfet due to Test only changes has not been reverted ([comment](#121284 (comment)))
@malfet malfet changed the title CI: add aarch64 linux workflow CI: add opt-in aarch64 linux workflow Apr 30, 2024
@malfet malfet requested review from malfet and atalman April 30, 2024 00:34
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are updating lint runner please update it for all platforms rather than for one (and if it could not be done for some reason mention it in PR description)

  • Do not make changes that would restrict usability for run_test.py for the purposes of CI, as users should be able to run them on their machines without any restrictions specific to CI
  • Do not leave the temporary changes in the workflow job (this supposed to be an opt-in workflow but now it runs on every pull, but not on trunk, which is wrong)

And please allow maintainers suggests changes to your PR, otherwise I could have re-landed it myself

@snadampal
Copy link
Collaborator Author

snadampal commented Apr 30, 2024

The CI summary says 4 unrelated failures and 2 new. But looking at the failure log, it seems all the 6 tests are unrelated, looks flaky. I was able to restart 2 of them, but didn't see any rerun jobs option for the rest.
cc: @malfet

@malfet
Copy link
Contributor

malfet commented Apr 30, 2024

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
aarch64 linux workflow is triggered for ciflow/aarch64 tags.

Pull Request resolved: #121284
Approved by: https://github.com/atalman, https://github.com/malfet
petrex pushed a commit to petrex/pytorch that referenced this pull request May 3, 2024
This reverts commit 32cf04c.

Reverted pytorch#121284 on behalf of https://github.com/malfet due to Test only changes has not been reverted ([comment](pytorch#121284 (comment)))
pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
Triggered by `ciflow/linux-aarch64` and runs only `test_modules`, `test_mkldnn`, `test_mkldnn_fusion` and `test_openmp` as test for now.
TODOS:
 - Enable sscache for fast CI
 - Extend to a more reasonable test coverage

Pull Request resolved: #121284
Approved by: https://github.com/atalman, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/linux-aarch64 linux aarch64 CI workflow ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants