[DCP][state_dict] Let _offload_state_dict_to_cpu to return the companion_obj if it exist. #121273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion_obj if it exist. As title [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/121273
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit bb3df9e with merge base 34a28f0 ( UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 8, 2024
…121276) As title Pull Request resolved: #121276 Approved by: https://github.com/wz337, https://github.com/LucasLLC ghstack dependencies: #121273
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 8, 2024
…21290) As title Pull Request resolved: #121290 Approved by: https://github.com/LucasLLC ghstack dependencies: #121273, #121276
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 12, 2024
Root may not exist due to FSDP lazy initialization. Pull Request resolved: #121544 Approved by: https://github.com/Skylion007 ghstack dependencies: #121273, #121276, #121290
mvpatel2000
pushed a commit
to mvpatel2000/pytorch
that referenced
this pull request
May 17, 2024
Root may not exist due to FSDP lazy initialization. Pull Request resolved: pytorch#121544 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#121273, pytorch#121276, pytorch#121290
atalman
pushed a commit
that referenced
this pull request
May 27, 2024
Root may not exist due to FSDP lazy initialization. Pull Request resolved: #121544 Approved by: https://github.com/Skylion007 ghstack dependencies: #121273, #121276, #121290 Co-authored-by: Chien-Chin Huang <chienchin@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As title
cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @penguinwu @XilunWu @wanchaol @fduwjj @wz337 @tianyu-l @wconstab @yf225 @chauhang @LucasLLC