Skip to content

[export] Convert internal tests to using .module() #119105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[export] Convert internal tests to using .module() #119105

wants to merge 1 commit into from

Conversation

angelayi
Copy link
Contributor

@angelayi angelayi commented Feb 3, 2024 •
edited by pytorch-bot bot
Loading

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53091904

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Feb 3, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/119105

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d5c6cf3 with merge base 029a16c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

angelayi added a commit to angelayi/executorch-1 that referenced this pull request Feb 3, 2024
@angelayi @facebook-github-bot
Convert internal tests to using .module() (#119105)
1da0f37 
Summary: Pull Request resolved: pytorch/pytorch#119105

Differential Revision: D53091904
angelayi added a commit to angelayi/pytorch that referenced this pull request Feb 3, 2024
@angelayi @facebook-github-bot
[export] Convert internal tests to using .module() (pytorch#119105)
c9eb537 
Summary: Pull Request resolved: pytorch#119105

Test Plan: CI

Differential Revision: D53091904
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53091904

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 3, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53091904

@angelayi @facebook-github-bot
[export] Convert internal tests to using .module() (pytorch#119105)
d5c6cf3 
Summary:
X-link: pytorch/executorch#1831


Test Plan: CI

Reviewed By: tarun292

Differential Revision: D53091904
angelayi added a commit to angelayi/executorch-1 that referenced this pull request Feb 8, 2024
@angelayi @facebook-github-bot
Convert internal tests to using .module() (pytorch#1831)
a3e9c16 
Summary:

X-link: pytorch/pytorch#119105

Reviewed By: tarun292

Differential Revision: D53091904
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D53091904

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Feb 8, 2024
@angelayi @facebook-github-bot
Convert internal tests to using .module() (#1831)
8699b98 
Summary:
Pull Request resolved: #1831

X-link: pytorch/pytorch#119105

Reviewed By: tarun292

Differential Revision: D53091904

fbshipit-source-id: 4c01c8a7eacb160b4d797a76a643e55075328973
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request Feb 8, 2024
@angelayi @jeffdaily
[export] Convert internal tests to using .module() (#119105)
76188e6 
Test Plan: CI

Differential Revision: D53091904

Pull Request resolved: #119105
Approved by: https://github.com/ydwu4
clee2000 pushed a commit that referenced this pull request Feb 14, 2024
@angelayi @clee2000
[export] Convert internal tests to using .module() (#119105)
16420ea 
Test Plan: CI

Differential Revision: D53091904

Pull Request resolved: #119105
Approved by: https://github.com/ydwu4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydwu4 ydwu4 ydwu4 approved these changes

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: dynamo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@angelayi @facebook-github-bot @pytorchmergebot @ydwu4