Skip to content

[quant][pt2e] Add fold_quantize=True for all convert_pt2e calls #117797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[quant][pt2e] Add fold_quantize=True for all convert_pt2e calls #117797

wants to merge 1 commit into from

Conversation

jerryzh168
Copy link
Contributor

Summary: In preparation for enabling fold_quantize=True by default

Test Plan: CI

Differential Revision: D52879612

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 18, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 18, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/117797

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 5189971 with merge base 8f91a53 (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52879612

@github-actions github-actions bot added the release notes: quantization release notes category label Jan 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52879612

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 19, 2024
jerryzh168 added a commit to jerryzh168/pytorch that referenced this pull request Jan 19, 2024
@jerryzh168 @facebook-github-bot
[quant][pt2e] Add fold_quantize=True for all convert_pt2e calls (pyto…
7bcd54c 
…rch#117797)

Summary:

X-link: pytorch/executorch#1640

In preparation for enabling fold_quantize=True by default

Test Plan: CI

Reviewed By: andrewor14

Differential Revision: D52879612
jerryzh168 added a commit to jerryzh168/executorch-1 that referenced this pull request Jan 19, 2024
@jerryzh168 @facebook-github-bot
Add fold_quantize=True for all convert_pt2e calls (pytorch#1640)
230ca88 
Summary:
X-link: pytorch/pytorch#117797


In preparation for enabling fold_quantize=True by default

Reviewed By: andrewor14

Differential Revision: D52879612
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52879612

@jerryzh168 @facebook-github-bot
[quant][pt2e] Add fold_quantize=True for all convert_pt2e calls (pyto…
5189971 
…rch#117797)

Summary:

X-link: pytorch/executorch#1640

In preparation for enabling fold_quantize=True by default

Test Plan: CI

Reviewed By: andrewor14

Differential Revision: D52879612
jerryzh168 added a commit to jerryzh168/executorch-1 that referenced this pull request Jan 20, 2024
@jerryzh168 @facebook-github-bot
Add fold_quantize=True for all convert_pt2e calls (pytorch#1640)
e7ab8b5 
Summary:
X-link: pytorch/pytorch#117797


In preparation for enabling fold_quantize=True by default

Reviewed By: andrewor14

Differential Revision: D52879612
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D52879612

facebook-github-bot pushed a commit to pytorch/executorch that referenced this pull request Jan 24, 2024
@jerryzh168 @facebook-github-bot
Add fold_quantize=True for all convert_pt2e calls (#1640)
017bf8d 
Summary:
X-link: pytorch/pytorch#117797

Pull Request resolved: #1640

In preparation for enabling fold_quantize=True by default

Reviewed By: andrewor14

Differential Revision: D52879612

fbshipit-source-id: a3db1319b8ee4fac713946453eafdcd437f63a7e
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -f 'Landed internally'

(Initiating merge automatically since Phabricator Diff has merged, using force because this PR might not pass merge_rules.json but landed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewor14 andrewor14 andrewor14 approved these changes

@digantdesai digantdesai Awaiting requested review from digantdesai

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: quantization release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerryzh168 @facebook-github-bot @pytorchmergebot @andrewor14