Skip to content

Add linux cpu test for 3.12 #113987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Add linux cpu test for 3.12 #113987

wants to merge 11 commits into from

Conversation

albanD
Copy link
Collaborator

@albanD albanD commented Nov 17, 2023 •
edited by pytorch-bot bot
Loading

@albanD albanD requested a review from a team as a code owner November 17, 2023 21:19
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 17, 2023
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 17, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/113987

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 5 Unrelated Failures

As of commit 5dd7076 with merge base 54d0455 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@albanD albanD added keep-going Don't stop on first failure, keep running tests until the end and removed topic: not user facing topic category labels Nov 17, 2023
@albanD albanD requested a review from jeffdaily as a code owner November 17, 2023 21:44
@albanD albanD added the topic: not user facing topic category label Nov 17, 2023
@albanD albanD force-pushed the 312_test_enablement branch 2 times, most recently from 142cd77 to 61ec579 Compare November 21, 2023 15:55
@albanD albanD force-pushed the 312_test_enablement branch from c3707af to 5dd7076 Compare November 22, 2023 20:10
@albanD albanD requested a review from malfet November 22, 2023 20:51
malfet
malfet approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder whenever one adds a config to the pull.yaml, they should consider removing one as well (i.e. why keep 3.11 config for non-inductor tests if we are already testing 3.12 one)

.github/workflows/pull.yml
Comment on lines +191 to +192
{ config: "dynamo", shard: 1, num_shards: 2, runner: "linux.2xlarge" },
{ config: "dynamo", shard: 2, num_shards: 2, runner: "linux.2xlarge" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we really run dynamo tests in 3.12?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I was curious what was going to be the failure and wanted to make sure it failed nicely.

@albanD
Copy link
Collaborator Author

albanD commented Nov 23, 2023 •
edited
Loading

The main failure for non-dynamo tests is due to missing lapack during compile.
From checking the logs, I'm not sure why we install both openblas and mkl in the ci env. And it seems like neither is being pickup up during compilation (The other builds pick up mkl but not openblas btw)

@atalman atalman mentioned this pull request Jan 19, 2024
Closed
@albanD
Copy link
Collaborator Author

albanD commented Jan 22, 2024

Closing in favor of #117853

@albanD albanD closed this Jan 22, 2024
pytorchmergebot pushed a commit that referenced this pull request Feb 14, 2024
@atalman @albanD @pytorchmergebot
Add linux cpu test for 3.12 (#117853)
244b124 
This is continuation of work: #113987

Co-authored-by: albanD <desmaison.alban@gmail.com>
Pull Request resolved: #117853
Approved by: https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees
No one assigned
Labels
keep-going Don't stop on first failure, keep running tests until the end module: dynamo topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albanD @malfet