-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[CD] Fix the libgomp twice load issue #150084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/150084
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 153ea95 with merge base 7243c69 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @malfet , could you please help to review this PR also which fix a high priority issue about bundled gomp in cpu wheels? The failures seems aren't related to the PR changes |
Hi @chuanqi129 what's the test plan for this PR? Or how one expects to verify that something is really fixed? |
Good question. We have verified it in local by @yuchengliu1 with the case from the issue #149422, but I also didn't figure out a good method to test it in CD whl smoke test script. @malfet any suggestion? |
Hi @chuanqi129 could you please post log of running the test from #149422 (comment) on the binary downloaded from https://github.com/pytorch/pytorch/actions/runs/14098800119?pr=150084 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From PR description (and lack of tests) it's unclear whether this change really fixes the reported issue or not
Update the test results with the latest changes as follows. Test results with the nightly wheel:
Test results with the fixed wheel:
|
@pytorchbot rebase -b viable/strict |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
9be80aa
to
153ea95
Compare
@pytorchmergebot merge -f "all required tests are passing" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot cherry-pick --onto release/2.7 -c critical |
Cherry picking #150084Command
Details for Dev Infra teamRaised by workflow job |
Fixes pytorch#149422 Pull Request resolved: pytorch#150084 Approved by: https://github.com/malfet, https://github.com/leslie-fang-intel, https://github.com/atalman Co-authored-by: LifengWang <lifeng.a.wang@intel.com>
Fixes pytorch#149422 Pull Request resolved: pytorch#150084 Approved by: https://github.com/malfet, https://github.com/leslie-fang-intel, https://github.com/atalman Co-authored-by: LifengWang <lifeng.a.wang@intel.com>
Fixes #149422 Pull Request resolved: #150084 Approved by: https://github.com/malfet, https://github.com/leslie-fang-intel, https://github.com/atalman Co-authored-by: LifengWang <lifeng.a.wang@intel.com>
Fixes #149422