Skip to content

Move trunk windows builds to CUDA-12.4 #145844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Move trunk windows builds to CUDA-12.4 #145844

wants to merge 1 commit into from

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jan 28, 2025 •
edited
Loading

Same as : #130446

That should catch build regressions that were previously only detectable during the nightly builds for 12.4

@atalman atalman requested a review from a team as a code owner January 28, 2025 15:46
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jan 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/145844

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 7 Pending

As of commit d5e5e6e with merge base 97b3b73 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 28, 2025
@atalman atalman added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 28, 2025
@janeyx99
Copy link
Contributor

Was this just an accidental miss from upgrading 12.4?

@atalman
Copy link
Contributor Author

atalman commented Jan 28, 2025 •
edited
Loading

@janeyx99 need to add it to our runbook https://github.com/pytorch/builder/blob/main/CUDA_UPGRADE_GUIDE.MD

@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 16:17 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 16:17 Inactive
@pytorch-bot pytorch-bot bot temporarily deployed to upload-benchmark-results January 28, 2025 16:17 Inactive
malfet
malfet approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we have some sort of an organized migration plan (there were dozen or so of CUDA-12.1->CUDA-12.4 migration PRs that picked up various leftovers)

@atalman
Copy link
Contributor Author

atalman commented Jan 28, 2025

Agree on this planning on adding all these PRs to the runbook: pytorch/builder@main/CUDA_UPGRADE_GUIDE.MD I believe it needs to be updated.

@atalman
Copy link
Contributor Author

atalman commented Jan 28, 2025

@pytorchmergebot merge -f "lint and windows build is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@anumol-baby anumol-baby mentioned this pull request Jun 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atalman @janeyx99 @pytorchmergebot @malfet