Skip to content

[ci, 3.13] disable failing cpp_extension test due to weights_only error in numpy 2.1 #141623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

[ci, 3.13] disable failing cpp_extension test due to weights_only error in numpy 2.1 #141623

wants to merge 11 commits into from

Conversation

williamwen42
Copy link
Member

@williamwen42 williamwen42 commented Nov 26, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 26, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/141623

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0d5223c with merge base 16676fd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@williamwen42 williamwen42 mentioned this pull request Nov 26, 2024
Closed
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 26, 2024
This was referenced Nov 26, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@williamwen42
Update on "[ci, 3.13] disable failing cpp_extension test due to weigh…
a16361c 
…ts_only error in numpy 2.1"

[ghstack-poisoned]
@williamwen42 williamwen42 mentioned this pull request Nov 27, 2024
Closed
@williamwen42
Update on "[ci, 3.13] disable failing cpp_extension test due to weigh…
e7449c4 
…ts_only error in numpy 2.1"

[ghstack-poisoned]
@williamwen42 williamwen42 mentioned this pull request Nov 27, 2024
Closed
@williamwen42
Copy link
Member Author

cc @mikaylagawarecki

@williamwen42
Update on "[ci, 3.13] disable failing cpp_extension test due to weigh…
49dad37 
…ts_only error in numpy 2.1"

[ghstack-poisoned]
@williamwen42
Update on "[ci, 3.13] disable failing cpp_extension test due to weigh…
a8c8ef3 
…ts_only error in numpy 2.1"

[ghstack-poisoned]
@williamwen42
Update on "[ci, 3.13] disable failing cpp_extension test due to weigh…
037a491 
…ts_only error in numpy 2.1"

[ghstack-poisoned]
This was referenced Dec 2, 2024
Closed
Closed
@williamwen42
Update on "[ci, 3.13] disable failing cpp_extension test due to weigh…
57e2e74 
…ts_only error in numpy 2.1"

[ghstack-poisoned]
This was referenced Dec 2, 2024
Closed
Closed
@mikaylagawarecki mikaylagawarecki self-requested a review December 2, 2024 15:43
This was referenced Dec 2, 2024
Closed
Closed
@williamwen42
Update on "[ci, 3.13] disable failing cpp_extension test due to weigh…
6618724 
…ts_only error in numpy 2.1"

[ghstack-poisoned]
mikaylagawarecki
mikaylagawarecki approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know how it fails in numpy >= 2.1 :o

@williamwen42
Copy link
Member Author

I installed numpy < 2.0 locally on 3.13 and the test passes.

pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] disable another failing cpp_extension test in 3.13 (pytorc…
f396886 
…h#141673)

Pull Request resolved: pytorch#141673
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] disable segfaulting profiler tests in 3.13 (pytorch#141674)
86bdbef 
Pull Request resolved: pytorch#141674
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[dynamo, 3.13] support CONVERT_VALUE (pytorch#141858)
cd4ec0e 
Pull Request resolved: pytorch#141858
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] skip dynamo-xpass'd numpy tests in numpy >= 2.0 (pytorch#1…
2fcc39c 
…41862)

Pull Request resolved: pytorch#141862
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[CI, 3.13] enable 3.13 CI (pytorch#139533)
ce3e09c 
Pull Request resolved: pytorch#139533
Approved by: https://github.com/atalman, https://github.com/malfet
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci] add 3.13 inductor unittests to CI (pytorch#140733)
3626125 
Pull Request resolved: pytorch#140733
Approved by: https://github.com/malfet, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[dynamo, 3.13] add JUMP_BACKWARD_NO_INTERRUPT to terminal opcodes (py…
21cf16d 
…torch#141859)

Pull Request resolved: pytorch#141859
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[dynamo, 3.13] disable 3.13.0 warning in dynamo-wrapped tests (pytorc…
bc6077b 
…h#141860)

Pull Request resolved: pytorch#141860
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] skip failing torch.package dynamo-wrapped test (pytorch#14…
82e76d0 
…1886)

Pull Request resolved: pytorch#141886
Approved by: https://github.com/PaliC
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] skip failing module tracker dynamo-wrapped test (pytorch#1…
3f7c8ae 
…41887)

Pull Request resolved: pytorch#141887
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests (pytorch#…
ca4c72e 
…141950)

Pull Request resolved: pytorch#141950
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[ci, 3.13] disable segfaulting dynamo-wrapped profiler test (pytorch#…
6ecd615 
…141951)

Pull Request resolved: pytorch#141951
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
pobin6 pushed a commit to pobin6/pytorch that referenced this pull request Dec 5, 2024
@williamwen42
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (pytorch#141264)
33f35d6 
Pull Request resolved: pytorch#141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950, pytorch#141951
@williamwen42 williamwen42 mentioned this pull request Dec 5, 2024
Closed
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable failing cpp_extension test due to weights_only err…
3d2b7cf 
…or in numpy 2.1 (pytorch#141623)

Pull Request resolved: pytorch#141623
Approved by: https://github.com/mikaylagawarecki, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable another failing cpp_extension test in 3.13 (#141673)
920c2dc 
Pull Request resolved: #141673
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable segfaulting profiler tests in 3.13 (#141674)
79e68f9 
Pull Request resolved: #141674
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[dynamo, 3.13] support CONVERT_VALUE (pytorch#141858)
b5ac556 
Pull Request resolved: pytorch#141858
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip dynamo-xpass'd numpy tests in numpy >= 2.0 (pytorch#1…
4d2a3bc 
…41862)

Pull Request resolved: pytorch#141862
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[CI, 3.13] enable 3.13 CI (#139533)
776adcc 
Pull Request resolved: #139533
Approved by: https://github.com/atalman, https://github.com/malfet
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci] add 3.13 inductor unittests to CI (pytorch#140733)
602e75a 
Pull Request resolved: pytorch#140733
Approved by: https://github.com/malfet, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[dynamo, 3.13] add JUMP_BACKWARD_NO_INTERRUPT to terminal opcodes (#1…
0bf73c9 
…41859)

Pull Request resolved: #141859
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[dynamo, 3.13] disable 3.13.0 warning in dynamo-wrapped tests (pytorc…
c1d0289 
…h#141860)

Pull Request resolved: pytorch#141860
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip failing torch.package dynamo-wrapped test (#141886)
86966d9 
Pull Request resolved: #141886
Approved by: https://github.com/PaliC
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] skip failing module tracker dynamo-wrapped test (#141887)
980eda7 
Pull Request resolved: #141887
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860, #141886
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] fix/skip failing numpy 2.0+ dynamo-wrapped tests (pytorch#…
ea06bac 
…141950)

Pull Request resolved: pytorch#141950
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887
AmdSampsa pushed a commit to AmdSampsa/pytorch that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[ci, 3.13] disable segfaulting dynamo-wrapped profiler test (pytorch#…
ba7e1dc 
…141951)

Pull Request resolved: pytorch#141951
Approved by: https://github.com/sraikund16, https://github.com/atalman
ghstack dependencies: pytorch#141409, pytorch#142003, pytorch#141572, pytorch#141577, pytorch#141605, pytorch#141621, pytorch#141623, pytorch#141673, pytorch#141674, pytorch#141858, pytorch#141862, pytorch#139533, pytorch#140733, pytorch#141859, pytorch#141860, pytorch#141886, pytorch#141887, pytorch#141950
pytorch-bot bot pushed a commit that referenced this pull request Dec 9, 2024
@williamwen42 @AmdSampsa
[CI, 3.13] enable dynamo_wrapped unittests in 3.13 (#141264)
8eff273 
Pull Request resolved: #141264
Approved by: https://github.com/StrongerXi, https://github.com/atalman
ghstack dependencies: #141409, #142003, #141572, #141577, #141605, #141621, #141623, #141673, #141674, #141858, #141862, #139533, #140733, #141859, #141860, #141886, #141887, #141950, #141951
@atalman atalman mentioned this pull request Dec 12, 2024
Closed
37 tasks
@github-actions github-actions bot deleted the gh/williamwen42/174/head branch January 4, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

Assignees
No one assigned
Labels
Merged topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williamwen42 @atalman @mikaylagawarecki @pytorchmergebot