Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

Adding Reactjs example for Image Classifier and Fixing Typo #1146

Merged
merged 19 commits into from
Oct 28, 2021
Merged

Adding Reactjs example for Image Classifier and Fixing Typo #1146

merged 19 commits into from
Oct 28, 2021

Conversation

AliceSum
Copy link
Contributor

@AliceSum AliceSum commented Jun 30, 2021 •
edited
Loading

Description

image
#1109

pytorch_model_bin -> pytorch_model.bin

Fixes #(issue)
It is just a typo in the original document.
pytorch_model_bin -> pytorch_model.bin

Type of change

pytorch_model_bin -> pytorch_model.bin

Adding a Reactjs example
Adding instructions to run the Reactjs example

Demo on the Torch Serve on Reactjs example.

Comment: This example follows the resnet18 example in the repo.

If you want to run it on your local machine, please check here:
https://github.com/JonathanSum/serve/tree/master/examples/image_classifier/resnet_18/ReactJSExample#readme

@AliceSum AliceSum changed the title Typo pytorch_model_bin -> pytorch_model.bin Adding Reactjs example and Fixing Typo Jul 9, 2021
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: 2e93cbc
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@HamidShojanazeri
Copy link
Collaborator

@JonathanSum Thanks a lot for your contribution, as part of best practices, it would be great in future to have separate PRs for different issues/improvements.

@AliceSum
Copy link
Contributor Author

AliceSum commented Jul 10, 2021 •
edited
Loading

Just an Update. I forgot to upload the build folder which has the deployed version of the react app.
The folder name is deployed.

@AliceSum AliceSum changed the title Adding Reactjs example and Fixing Typo Adding Reactjs example for image classifier and Fixing Typo Jul 10, 2021
@AliceSum AliceSum changed the title Adding Reactjs example for image classifier and Fixing Typo Adding Reactjs example for Image Classifier and Fixing Typo Jul 10, 2021
@AliceSum
Copy link
Contributor Author

I am just thinking or asking. I need to know there is a way to implement torch-serve in javascript or in either c++ or python without restful, so we can run the torch serve with model fully in the browser with reactjs. If so, we can even deploy it on github page.

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: d87bc0c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@chauhang
Copy link
Contributor

@nskool Can you please check why the build logs are not getting published?

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 7e34851
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 7e34851
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: 7e34851
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: dcff340
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: dcff340
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nikhil-sk nikhil-sk closed this Sep 29, 2021
@nikhil-sk nikhil-sk reopened this Sep 29, 2021
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: dcff340
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: dcff340
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@AliceSum
Copy link
Contributor Author

AliceSum commented Oct 3, 2021

Should I click the update branch button next to the "This branch is out-of-date with the base branch"?

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: bba17ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: bba17ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: bba17ad
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 7477ba7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 7477ba7
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: 7477ba7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lxning lxning added the enhancement New feature or request label Oct 27, 2021
@lxning lxning added this to the v0.4.3 milestone Oct 27, 2021
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: 6efe211
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 6efe211
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@chauhang chauhang merged commit e363ace into pytorch:master Oct 28, 2021
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: 6efe211
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@chauhang chauhang chauhang approved these changes

@HamidShojanazeri HamidShojanazeri HamidShojanazeri approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
7 participants
@AliceSum @sagemaker-neo-ci-bot @HamidShojanazeri @chauhang @nikhil-sk @lxning @msaroufim