Verify types in custom op schemas #3705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3705
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 31d0c18 with merge base 16a892d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D57666659 |
zou3519
added a commit
to zou3519/pytorch
that referenced
this pull request
May 22, 2024
Summary: X-link: pytorch/executorch#3705 co-dev reland of pytorch#124520, which requires the removal of some executorch tests. Before this PR, we didn't check that types in a schema were valid. This is because TorchScript treats unknown types as type variables. This PR checks types in a schema for the TORCH_LIBRARY APIs. To do this, we add an `allow_typevars` flag to parseSchema so that TorchScript can use allow_typevars=True. We also add some error messages for common mistakes (e.g. using int64_t or double in schema). Test Plan: Wait for tests Differential Revision: D57666659
zou3519
added a commit
to zou3519/executorch
that referenced
this pull request
May 22, 2024
Summary: X-link: pytorch/pytorch#126861 co-dev reland of pytorch/pytorch#124520, which requires the removal of some executorch tests. Before this PR, we didn't check that types in a schema were valid. This is because TorchScript treats unknown types as type variables. This PR checks types in a schema for the TORCH_LIBRARY APIs. To do this, we add an `allow_typevars` flag to parseSchema so that TorchScript can use allow_typevars=True. We also add some error messages for common mistakes (e.g. using int64_t or double in schema). Differential Revision: D57666659
|
This pull request was exported from Phabricator. Differential Revision: D57666659 |
Summary: X-link: pytorch/pytorch#126861 co-dev reland of pytorch/pytorch#124520, which requires the removal of some executorch tests. Before this PR, we didn't check that types in a schema were valid. This is because TorchScript treats unknown types as type variables. This PR checks types in a schema for the TORCH_LIBRARY APIs. To do this, we add an `allow_typevars` flag to parseSchema so that TorchScript can use allow_typevars=True. We also add some error messages for common mistakes (e.g. using int64_t or double in schema). Reviewed By: albanD Differential Revision: D57666659
zou3519
added a commit
to zou3519/pytorch
that referenced
this pull request
May 22, 2024
Summary: X-link: pytorch/executorch#3705 co-dev reland of pytorch#124520, which requires the removal of some executorch tests. Before this PR, we didn't check that types in a schema were valid. This is because TorchScript treats unknown types as type variables. This PR checks types in a schema for the TORCH_LIBRARY APIs. To do this, we add an `allow_typevars` flag to parseSchema so that TorchScript can use allow_typevars=True. We also add some error messages for common mistakes (e.g. using int64_t or double in schema). Test Plan: Wait for tests Reviewed By: albanD Differential Revision: D57666659
|
This pull request was exported from Phabricator. Differential Revision: D57666659 |
|
This pull request has been merged in 1dd4935. |
kirklandsign
pushed a commit
to kirklandsign/executorch
that referenced
this pull request
May 24, 2024
Summary: X-link: pytorch/pytorch#126861 Pull Request resolved: pytorch#3705 co-dev reland of pytorch/pytorch#124520, which requires the removal of some executorch tests. Before this PR, we didn't check that types in a schema were valid. This is because TorchScript treats unknown types as type variables. This PR checks types in a schema for the TORCH_LIBRARY APIs. To do this, we add an `allow_typevars` flag to parseSchema so that TorchScript can use allow_typevars=True. We also add some error messages for common mistakes (e.g. using int64_t or double in schema). Reviewed By: albanD Differential Revision: D57666659 fbshipit-source-id: 25b0c247229ea78966725a3678dd01fdcc02c91d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
co-dev reland of pytorch/pytorch#124520, which requires
the removal of some executorch tests.
Before this PR, we didn't check that types in a schema were valid. This
is because TorchScript treats unknown types as type variables.
This PR checks types in a schema for the TORCH_LIBRARY APIs. To do this,
we add an
allow_typevarsflag to parseSchema so that TorchScript canuse allow_typevars=True. We also add some error messages for common
mistakes (e.g. using int64_t or double in schema).
Differential Revision: D57666659