This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Python 3.13t changes required to build python 3.13t wheel #2001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update build_common.sh Update build_common.sh Update build_common.sh Update check_binary.sh Update check_binary.sh Update check_binary_symbols.py Update check_binary.sh Update check_binary_symbols.py
atalman
commented
Oct 1, 2024
| @@ -78,10 +78,14 @@ def check_lib_symbols_for_abi_correctness(lib: str, pre_cxx11_abi: bool = True) | |||
| raise RuntimeError("Didn't find enought cxx11 symbols") | |||
|
|
|||
| def main() -> None: | |||
| if os.getenv("PACKAGE_TYPE") == "libtorch": | |||
| install_root = Path(os.getcwd()) | |||
| if "install_root" in os.environ: | |||
There was a problem hiding this comment.
install_root is set in check_binary already, hence if its set - no need to figure it out.
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 2, 2024
Builder PR required: pytorch/builder#2001 Test PR: #136490 Pull Request resolved: #137127 Approved by: https://github.com/albanD
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Oct 3, 2024
Builder PR required: pytorch/builder#2001 Test PR: #136490 Pull Request resolved: #137127 Approved by: https://github.com/albanD
malfet
added a commit
that referenced
this pull request
Oct 3, 2024
#2001 added trailing spaces to it, so let's ruff it by default
malfet
added a commit
that referenced
this pull request
Oct 3, 2024
* [CI] Lint check_binary_symbols #2001 added trailing spaces to it, so let's ruff it by default * Fix lint issues
37 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required to enable Python 3.13t.
Test: pytorch/pytorch#136490