Skip to content

Conversation

cehongwang
Copy link
Collaborator

Description

Fixed layernorm when weight and bias is None in Stable Diffusion 3

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x] My code follows the style guidelines of this project (You can use the linters)
  • [ x] I have performed a self-review of my own code
  • [ x] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x] I have made corresponding changes to the documentation
  • [ x] I have added tests to verify my fix or my feature
  • [ x] New and existing unit tests pass locally with my changes
  • [ x] I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 18, 2024
@github-actions github-actions bot requested a review from narendasan June 18, 2024 19:31
@narendasan
Copy link
Collaborator

Can you add a test case if possible?

@github-actions github-actions bot added the component: tests Issues re: Tests label Jun 24, 2024
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit f3035be into main Jun 24, 2024
@narendasan narendasan deleted the layernorm-bug-fix branch June 24, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants