Skip to content

cherry-pick: Add release flag for nightly build tag (#2821) #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 4, 2024
Merged

cherry-pick: Add release flag for nightly build tag (#2821) #2835

merged 2 commits into from
Jun 4, 2024

Conversation

gs-olive
Copy link
Collaborator

Description

Type of change

  • Cherry-pick

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this May 14, 2024
peri044
peri044 reviewed May 17, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted a question

peri044
peri044 reviewed May 17, 2024
View reviewed changes
packaging/pre_build_script_windows.sh
@@ -6,3 +6,5 @@ python -m pip install tensorrt==10.0.0b6 tensorrt-${CU_VERSION::4}-bindings==10.
choco install bazelisk -y

cat toolchains/ci_workspaces/WORKSPACE.win.release.tmpl | envsubst > WORKSPACE

echo "RELEASE=1" >> ${GITHUB_ENV}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this related to channel=release in the yml files ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussion here: #2806 (comment), this flag seems to get the package naming correct on the Torch upload index. I do not think it directly relates to the channel from the .yml files.

@gs-olive gs-olive added the ciflow/binaries/all Build for all Python Versions label Jun 4, 2024
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 4, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@gs-olive gs-olive force-pushed the cherry_pick_release_flag branch from ec702bd to 1a07128 Compare June 4, 2024 04:00
@github-actions github-actions bot added the component: tests Issues re: Tests label Jun 4, 2024
@lanluo-nvidia lanluo-nvidia merged commit b461bd3 into release/2.3 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 left review comments

Assignees

@gs-olive gs-olive

Labels
ciflow/binaries/all Build for all Python Versions cla signed component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gs-olive @peri044 @facebook-github-bot @lanluo-nvidia