add log normal negative binomial distributions #3010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
reviewed
Jan 24, 2022
martinjankowiak
commented
Jan 26, 2022
martinjankowiak
commented
Jan 26, 2022
|
@fritzo this should be ready for review, at your convenience |
|
docs preview |
fritzo
requested changes
Jan 26, 2022
There was a problem hiding this comment.
Can you append one or two test cases to the end of [this list](
pyro/tests/distributions/conftest.py
Line 662 in 65225ae
tests/distributions/conftest.py?
|
@fritzo this should be good to go unless additional tests are required (don't think so) |
fritzo
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a 3-parameter generalization of the negative binomial distribution.