Added tests for JIT Elbo classes in test_valid_models #2799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 8, 2021 14:56
added hundreds of failing tests (and a few passing ones)
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was attempting to fix #2798 by simply adding a minus sign to the
JitTraceGraph_ELBOclass and discovered some issues while testing. As I cannot figure out what is going on, @fritzo suggested I open a PR with failing tests for someone else to look at.So, for every use of an ELBO in
test_valid_models, I added another test that used the Jit version of that ELBO if there was one. For a few tests this meant introducing parametrization (the TraceMeanField_ELBO tests lived on their own, and now they have a parameter for the normal and Jit class). Also, in cases where the test usedif Elbo is TraceEnum_ELBOI changed it toif issubclass(Elbo, TraceEnum_ELBO)so that the Jit version is included.This adds more than 200 failing tests (and some passing ones as well). 😬 I suspect that many of them are simply because the test model is not compatible with JITting, but it also uncovers a number where the outputs simply don't match the expected value from
JitTraceGraph_ELBOandJitTraceMeanField_ELBO.