Skip to content

Switch to Apache 2.0 license #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 10, 2020
Merged

Switch to Apache 2.0 license #2250

merged 8 commits into from
Jan 10, 2020

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Jan 10, 2020

Addresses #2249 #2067

  1. Switch from MIT to Apache-2.0 license
    • update LICENSE.md
    • update setup.py
  2. Add a script to add copyright notices and SPDX identifiers to all .py and .cpp files.
  3. Apply the script to all source files

I plan to update and modify the script as we e.g. update the copyright year next year or add new file types.

After this PR merges we can disable the Uber CLA 🎉

@neerajprad we will also need to switch licenses in other repos:

@fritzo fritzo requested a review from neerajprad January 10, 2020 18:51
@fritzo
Copy link
Member Author

fritzo commented Jan 10, 2020

cc @swinslow @ibrahimhaddad

@@ -0,0 +1,54 @@
# Copyright (c) 2020 Contributors to the Pyro project.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neerajprad here is the new script file

Copy link
Member

@neerajprad neerajprad Jan 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @fritzo. Should we do this for the other projects in pyro-ppl too? EDIT: Yes, just saw your comment above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should do this for all repos in https://github.com/pyro-ppl.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll make the changes for numpyro and pyro-api.

neerajprad
neerajprad previously approved these changes Jan 10, 2020
swinslow
swinslow previously approved these changes Jan 10, 2020
@fritzo
Copy link
Member Author

fritzo commented Jan 10, 2020

@neerajprad I've updated to use @swinslow's recommended simpler copyright notices.

neerajprad
neerajprad previously approved these changes Jan 10, 2020
@fritzo
Copy link
Member Author

fritzo commented Jan 10, 2020

@neerajprad I have reverted to preserve Uber copyrights on existing files following advice from our Uber lawyer. The scripts/update_headers.py can remain as-is, since we can use @swinslow's simplified copyright notice for new files.

@neerajprad neerajprad merged commit b319636 into dev Jan 10, 2020
@fritzo fritzo deleted the apache-2.0 branch January 15, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants