Skip to content

Possible bug in poutine/trace_messenger.py, function identify_dense_edges #3245

@xrival

Description

@xrival

Hi,

I found some strange code pattern in function identify_dense_edges, in file poutine/trace_messenger.py.
I notice two sequential instances of:
if site_is_subsample(node): continue
The first one appears at line 17 (in the main loop of the function) and the second one at line 21 (in the nested loop).
It seems the second condition will never be reached; if it is, the first one would be selected, going to the next iteration of the main loop.

Should the second not be as follows ?
if site_is_subsample(past_node): continue

(this would be consistent with considering only pairs of non subsample nodes).

Thanks,

Regards,

Xavier

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions